Add firestore/CPPLINT.cfg #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot dismissed var-const’s stale review 🍞 Dismissed stale approval on external PR.
var-const approved these changes Jul 29, 2021
github-actions bot added the tests: in-progress 
✅ Integration test succeeded!Requested by @dconeybe on commit 45beab3 |
github-actions bot added the tests: succeeded 
firebase-workflow-trigger bot removed the tests: in-progress 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The new
CPPLINT.cfgjust disables some noisy checks:runtime/references- This category produces warnings likeIs this a non-const reference? If so, make const or use a pointer: TestData& test_databuild/c++11- This category produces warnings like<mutex> is an unapproved C++11 header.