Skip to content

Resolve macros related to STLPort. #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2021
Merged

Resolve macros related to STLPort. #486

merged 6 commits into from
Jun 24, 2021

Conversation

@ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jun 22, 2021

The following should be true going forward:
FIREBASE_USE_STD_FUNCTION: Always defined
STLPORT: Always undefined
_STLPORT_VERSION: Always undefined
So we can simplify the code on this basis.

More changes to come related to removal of STLPort:

  • Removing AddSnapshotListener and AddSnapshotsInSyncListener (and RunTransaction?) variants that use EventListener
  • Removing EventListener
  • Removing STLPort-specific workarounds in the code on a case-by-case basis
  • Move to C++11 standard definitions of move, unique_ptr, shared_ptr, etc. where applicable
@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@ehsannas ehsannas requested a review from var-const June 22, 2021 20:32
@ehsannas ehsannas changed the title Resolve macros related to STLPort. Read more: Resolve macros related to STLPort. Jun 22, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Jun 23, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jun 23, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit 17867c7
Last updated: Thu Jun 24 15:39 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore
(5 items)[BUILD] [ERROR] [Android] [All os]
[BUILD] [ERROR] [Linux] [All ssl_lib]
[BUILD] [ERROR] [MacOS] [All ssl_lib]
[BUILD] [ERROR] [Windows] [All ssl_lib]
[BUILD] [ERROR] [iOS] [macos]
functions [BUILD] [ERROR] [Android] [windows]
installations [TEST] [FAILURE] [Android] [macos] [android_latest]
(1 failed tests)  TestGettingTokenTwiceMatches

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 23, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2021
var-const
var-const suggested changes Jun 24, 2021
View reviewed changes
@var-const var-const assigned ehsannas and unassigned var-const Jun 24, 2021
@ehsannas ehsannas requested a review from var-const June 24, 2021 15:25
@ehsannas ehsannas assigned var-const and unassigned ehsannas Jun 24, 2021
@ehsannas
Copy link
Contributor Author

ehsannas commented Jun 24, 2021

Also rebased against main
@var-const var-const assigned ehsannas and unassigned var-const Jun 24, 2021
var-const
var-const previously approved these changes Jun 24, 2021
View reviewed changes
@ehsannas ehsannas removed the tests: failed This PR's integration tests failed. label Jun 24, 2021
ehsannas added 3 commits June 24, 2021 13:20
@ehsannas
Resolve macros related to STLPort. Read more:
b2bfc49 
FIREBASE_USE_STD_FUNCTION: Always defined STLPORT: Always undefined _STLPORT_VERSION: Always undefined
@ehsannas
Address code review.
34134b1
@ehsannas
Remove the fn definition/declarations that are only defined for DOXYGEN.
d9fdc8a
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Jun 24, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 24, 2021
@ehsannas
Copy link
Contributor Author

ehsannas commented Jun 24, 2021

Rebased again to resolve merge conflicts
@ehsannas ehsannas requested a review from var-const June 24, 2021 18:27
@ehsannas ehsannas assigned var-const and unassigned ehsannas Jun 24, 2021
@var-const var-const assigned ehsannas and unassigned var-const Jun 24, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@ehsannas ehsannas assigned var-const and unassigned ehsannas Jun 24, 2021
@var-const var-const assigned ehsannas and unassigned var-const Jun 24, 2021
@ehsannas ehsannas merged commit 17867c7 into main Jun 24, 2021
@ehsannas ehsannas deleted the remove-stlport-1 branch June 24, 2021 20:42
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 24, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
ehsannas added a commit that referenced this pull request Jun 25, 2021
@ehsannas
Roll back #486
96065f0
ehsannas added a commit that referenced this pull request Jun 25, 2021
@ehsannas
Roll back #486 (#495)
3177560
jonsimantov pushed a commit that referenced this pull request Jul 1, 2021
@ehsannas @jonsimantov
Resolve macros related to STLPort. (#486)
b468a72 
* Resolve macros related to STLPort. Read more: FIREBASE_USE_STD_FUNCTION: Always defined STLPORT: Always undefined _STLPORT_VERSION: Always undefined * Address code review. * Remove the fn definition/declarations that are only defined for DOXYGEN. * Remove EventListener from public API. * Address code review. * Remove event_listener.h from app/CMakeLists.txt.
jonsimantov pushed a commit that referenced this pull request Jul 1, 2021
@ehsannas @jonsimantov
Roll back #486 (#495)
00db236
@ehsannas ehsannas mentioned this pull request Jul 5, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes tests: failed This PR's integration tests failed.

2 participants

@ehsannas @var-const