- Notifications
You must be signed in to change notification settings - Fork 127
Feature/python scripts update ios android dependencies #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/python scripts update ios android dependencies #420
Conversation
Get latest versions of cocoapods from Cocoapods Specs repo and update podfiles in repo.
Older format with a dependency listed per line is more suitable for automated scripts that do regex substitutions of versions.
I didn't read through the PR yet, but it should also update release_build_files/Android/firebase_dependencies.gradle and product/integration_test_internal/Podfile - if it does that already, you should update the PR description. :) |
| As the iOS dependencies got updated at the same time.
I believe it's safe to remove the file and code here: |
… of https://github.com/firebase/firebase-cpp-sdk into feature/python-scripts-update-ios-android-dependencies
Awesome. Thanks for catching this. I didn't realize there was another firebase_dependencies file in the repo. |
Great point Mou! I will handle the cleanup of these files (and corresponding code) in a separate PR and add you as a reviewer. |
sunmou99 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DellaBitta left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some nits.
alexames left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought my comments went in yesterday but I guess I didn't hit the submit button.
Script that updates versions of iOS Cocoapods and Android packages across various files in the repository,
ios_pods/Podfile<firebase_product>/integration_tests/Podfile<firebase_product>/integration_tests_internal/PodfileAndroid/firebase_dependencies.gradlerelease_build_files/Android/firebase_dependencies.gradlerelease_build_files/readme.md*/build.gradleSimple usage of the script,
// To preview substitutions that will be made
python3 scripts/update_ios_android_dependencies.py --dryrun// Update versions in default set of files in the repository
python3 scripts/update_ios_android_dependencies.pyFor the scripts to work correctly, this PR had to be undone and older release notes format had to be restored. In the older format, there was atmost one dependency (pod or android package) specified per line and this made it way easier to read and process for regex substitutions.
For testing, I created a duplicate test branch and "zeroed" out all versions and ran the script. Here is the commit with the changes,
887da08
Also, Firebase/AdMob Cocoapod is now updated to Google-Mobile-Ads-SDK Cocoapod in the readme.