Skip to content

Conversation

@DellaBitta
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Feature branch with breaking changes for Google I/0 '23

Do not merge.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

TBD.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.


EXPECT_TRUE(auth_->current_user_DEPRECATED()->is_valid());
EXPECT_TRUE(auth_->current_user_DEPRECATED()->is_anonymous());
EXPECT_TRUE(auth_->current_user_DEPRECATED()->uid().size() != 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Lint warning: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b)


EXPECT_TRUE(auth_->current_user().is_valid());
EXPECT_TRUE(auth_->current_user().is_anonymous());
EXPECT_TRUE(auth_->current_user().uid().size() != 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Lint warning: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b)


/// @deprecated This is a deprecated method. Please use
/// @CreateUserWithEmailAndPassword instead.
///

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: Found unknown command '\CreateUserWithEmailAndPassword'

User current_user();

/// @deprecated This is a deprecated method. Please use @current_user instead.
///

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: Found unknown command '\current_user'


/// @deprecated This is a deprecated method. Please use
/// @SignInAndRetrieveDataWithCredential instead.
///

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: Found unknown command '\SignInAndRetrieveDataWithCredential'

const;

/// @deprecated This is a deprecated method. Please use @SignInWithCredential
/// instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: Found unknown command '\SignInWithCredential'

/// instead.
///
/// Convenience method for @ref SignInAndRetrieveDataWithCredential that
/// doesn't return additional identity provider data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'SignInAndRetrieveDataWithCredential' for \ref command


/// @deprecated
///
/// Get results of the most recent call to @ref ReauthenticateAndRetrieveData.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command

ReauthenticateAndRetrieveDataLastResult_DEPRECATED() const;

/// @deprecated This is a deprecated method. Please use
/// @ref ReauthenticateWithProvider(FederatedAuthProvider*) instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateWithProvider(FederatedAuthProvider*)' for \ref command

Future<SignInResult> LinkWithProvider_DEPRECATED(
FederatedAuthProvider* provider) const;

/// @deprecated This is a deprecated method. Please use @ref Unlink(const

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command


/// @deprecated
///
/// Get results of the most recent call to @ref Unlink.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command

Future<User*> UnlinkLastResult_DEPRECATED() const;

/// @deprecated This is a deprecated method. Please use
/// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command

@DellaBitta
Copy link
Contributor Author

Closing PR to rename branch.

@DellaBitta DellaBitta closed this Apr 2, 2023
@firebase firebase locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant