- Notifications
You must be signed in to change notification settings - Fork 127
Auth changes for Google I/O 23 #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| | ||
| EXPECT_TRUE(auth_->current_user_DEPRECATED()->is_valid()); | ||
| EXPECT_TRUE(auth_->current_user_DEPRECATED()->is_anonymous()); | ||
| EXPECT_TRUE(auth_->current_user_DEPRECATED()->uid().size() != 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using EXPECT_NE instead of EXPECT_TRUE(a != b)
| | ||
| EXPECT_TRUE(auth_->current_user().is_valid()); | ||
| EXPECT_TRUE(auth_->current_user().is_anonymous()); | ||
| EXPECT_TRUE(auth_->current_user().uid().size() != 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using EXPECT_NE instead of EXPECT_TRUE(a != b)
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @CreateUserWithEmailAndPassword instead. | ||
| /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\CreateUserWithEmailAndPassword'
| User current_user(); | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @current_user instead. | ||
| /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\current_user'
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @SignInAndRetrieveDataWithCredential instead. | ||
| /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\SignInAndRetrieveDataWithCredential'
| const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @SignInWithCredential | ||
| /// instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\SignInWithCredential'
| /// instead. | ||
| /// | ||
| /// Convenience method for @ref SignInAndRetrieveDataWithCredential that | ||
| /// doesn't return additional identity provider data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'SignInAndRetrieveDataWithCredential' for \ref command
| | ||
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref ReauthenticateAndRetrieveData. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command
| ReauthenticateAndRetrieveDataLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref ReauthenticateWithProvider(FederatedAuthProvider*) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateWithProvider(FederatedAuthProvider*)' for \ref command
| Future<SignInResult> LinkWithProvider_DEPRECATED( | ||
| FederatedAuthProvider* provider) const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @ref Unlink(const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| | ||
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref Unlink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| Future<User*> UnlinkLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command
| Closing PR to rename branch. |
Description
Feature branch with breaking changes for Google I/0 '23
Do not merge.
Testing
TBD.
Type of Change
Place an
xthe applicable box: