Skip to content

Add warning for known issue b/328687152 #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Add warning for known issue b/328687152 #6755

merged 1 commit into from
Mar 11, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 11, 2025

Detect and log the following warning for the known issue https://issuetracker.google.com/328687152

Your app is experiencing a known issue in the Android Gradle plugin, see https://issuetracker.google.com/328687152 It affects Java-only apps using AGP version 8.3.2 and under. To avoid the issue, either: 1. Upgrade Android Gradle plugin to 8.4.0+ Follow the guide at https://developer.android.com/build/agp-upgrade-assistant 2. Or, add the Kotlin plugin to your app Follow the guide at https://developer.android.com/kotlin/add-kotlin 3. Or, do the technical workaround described in https://issuetracker.google.com/issues/328687152#comment3
@mrober mrober requested review from rlazo and themiswang March 11, 2025 15:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from 71.96% (9340503) to 71.35% (be93281) by -0.60%.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8lXag0Of1x.html
@github-actions GitHub Actions
Copy link
Contributor

Test Results

 38 files  ±0   38 suites  ±0   54s ⏱️ -1s
 95 tests ±0   95 ✅ ±0  0 💤 ±0  0 ❌ ±0 
190 runs  ±0  190 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f232c9d. ± Comparison against base commit 9340503.
@mrober mrober merged commit c9287ee into main Mar 11, 2025
40 checks passed
@mrober mrober deleted the mrober/logwarning branch March 11, 2025 15:14
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-sessions

    TypeBase (9340503)Merge (be93281)Diff
    aar190 kB192 kB+1.71 kB (+0.9%)
    apk (aggressive)377 kB378 kB+1.04 kB (+0.3%)
    apk (release)6.31 MB6.31 MB+1.51 kB (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TRXK2BexvB.html
rlazo pushed a commit that referenced this pull request Mar 11, 2025
@mrober @rlazo
Add warning for known issue b/328687152 (#6755)
c188fac
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@mrober @tejasd
Add warning for known issue b/328687152 (#6755)
a59649e
@firebase firebase locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

main-merge-ack size/S

4 participants

@mrober @google-oss-bot @rlazo @themiswang