Bump well known types #6716
Merged
Bump well known types #6716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.3 {: #firestore_v25-1-3} * {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external} #### {{firestore}} Kotlin extensions version 25.1.3 {: #firestore-ktx_v25-1-3} The Kotlin extensions library transitively includes the updated `firebase-firestore` library. The Kotlin extensions library has no additional updates. firebase-inappmessaging-display### {{inappmessaging}} Display version 21.0.2 {: #inappmessaging-display_v21-0-2} * {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external} #### {{inappmessaging}} Display Kotlin extensions version 21.0.2 {: #inappmessaging-display-ktx_v21-0-2} The Kotlin extensions library transitively includes the updated `firebase-inappmessaging-display` library. The Kotlin extensions library has no additional updates. firebase-inappmessaging### {{inappmessaging}} version 21.0.2 {: #inappmessaging_v21-0-2} * {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external} #### {{inappmessaging}} Kotlin extensions version 21.0.2 {: #inappmessaging-ktx_v21-0-2} The Kotlin extensions library transitively includes the updated `firebase-inappmessaging` library. The Kotlin extensions library has no additional updates. firebase-perf### {{perfmon}} version 21.0.5 {: #performance_v21-0-5} * {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external} #### {{perfmon}} Kotlin extensions version 21.0.5 {: #performance-ktx_v21-0-5} The Kotlin extensions library transitively includes the updated `firebase-perf` library. The Kotlin extensions library has no additional updates. The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from. Changelogsprotolite-well-known-types |
Coverage Report 1This report is too large (93,471 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Test Results 360 files + 340 360 suites +340 9m 2s ⏱️ + 8m 50s Results for commit b7c6043. ± Comparison against base commit 22be120. This pull request removes 116 and adds 2522 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
rlazo reviewed Feb 24, 2025
rlazo approved these changes Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per b/398840288,
This bumps
protolite-well-known-typesto properly utilize3.25.5. It seems as though this was an oversight in #6343, but since gradle uses the highest version when resolving dependency conflicts (and all the existing libraries already use3.25.5), this isn't a major issue. This is only really an issue if someone is usingprotolite-well-known-typesin isolation (which isn't really a use-case we're shipping for). But the main reason for fixing this is that it causes a bit of confusion when trying to track dependency issues (see issue #6674 for an example of this).Fixes #6674