dataconnect: Rename FirebaseDataConnectExperimental to ExperimentalFirebaseDataConnect #6433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rebaseDataConnect to follow the idiomatic naming
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-dataconnect### {{data_connect_short}} version 16.0.0-beta03 {: #data-connect_v16-0-0-beta03} * {{changed}} Requires Data Connect emulator version 1.6.1 or later for code generation. * {{feature}} QueryRef and MutationRef gain methods copy(), withDataDeserializer(), and withVariablesSerializer(). (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) * {{feature}} GeneratedConnector gains methods copy(), operations(), queries(), and mutations(). (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) * {{feature}} GeneratedQuery and GeneratedMutation gain methods copy(), withVariablesSerializer(), and withDataDeserializer(). (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) * {{feature}} GeneratedConnector, GeneratedQuery, and GeneratedMutation now must implement equals() to be a _logical_ comparsion, rather than just checking for _referencial_ equality using the `===` operator. (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) * {{feature}} ExperimentalFirebaseDataConnect annotation added, and some APIs have been annotated with it, requiring applications that make use of these experimental APIs to opt-in using `@OptIn(ExperimentalFirebaseDataConnect::class)` to suppress warnings or errors related to using these experimental APIs. (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) and (GitHub [#6433](//github.com/firebase/firebase-android-sdk/issues/6433){: .external}) |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check |
aashishpatil-g approved these changes Nov 5, 2024
dconeybe deleted the dconeybe/dataconnect/ExperimentalFirebaseDataConnect branch 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The previous PR #6424 named the "experimental" annotation
FirebaseDataConnectExperimental; however, a more idiomatic name isExperimentalFirebaseDataConnect, based on other similar classes from popular libraries, such asExperimentalKotest,ExperimentalSerializationApi, andExperimentalCoroutinesApi.