Rename BlockThreshold to HarmBlockThreshold #6262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This better matches the backend API.
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2024-09-30 16:26:18.882281615 +0000 +++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2024-09-30 16:24:10.633729758 +0000 @@ -29,7 +29,7 @@ </table> </div> <hr> - <p>Represents the threshold for some <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> that is allowed and blocked by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> + <p>Represents the threshold for a <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> to be allowed by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> <h2>Summary</h2> <div class="devsite-table-wrapper"> <table class="responsive">--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html 2024-09-30 16:26:18.880281608 +0000 +++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html 2024-09-30 16:24:10.631729750 +0000 @@ -245,7 +245,7 @@ <tr> <td><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td> <td> - <p>Represents the threshold for some <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> that is allowed and blocked by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> + <p>Represents the threshold for a <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> to be allowed by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> </td> </tr> <tr>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2024-09-30 16:26:18.874281585 +0000 +++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2024-09-30 16:24:10.625729723 +0000 @@ -29,7 +29,7 @@ </table> </div> <hr> - <p>Represents the threshold for some <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> that is allowed and blocked by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> + <p>Represents the threshold for a <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> to be allowed by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> <h2>Summary</h2> <div class="devsite-table-wrapper"> <table class="responsive">--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html 2024-09-30 16:26:18.872281578 +0000 +++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html 2024-09-30 16:24:10.623729715 +0000 @@ -316,7 +316,7 @@ <tr> <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td> <td> - <p>Represents the threshold for some <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> that is allowed and blocked by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> + <p>Represents the threshold for a <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> to be allowed by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code>.</p> </td> </tr> <tr> |
Coverage Report 1Affected ProductsNo changes between base commit (da0eefa) and merge commit (445343b).Test Logs |
Size Report 1Affected Products
Test Logs |
| Let's hold off on submitting this until we have a discussion if it makes sense to break - and the strategy for doing so (should we deprecate and introduce a new type, how could that work, etc) |
| @daymxn @emilypgoogle this is OK to review now, thanks! |
daymxn approved these changes Sep 24, 2024
Generated by 🚫 Danger |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This better matches the backend API.