Add issubclass check for init_resources

Author: ZipFile

src/dependency_injector/containers.pyx

@@ -335,6 +335,10 @@ class DynamicContainer(Container):
 
  def init_resources(self, resource_type=providers.Resource):
  """Initialize all container resources."""
+
+ if not issubclass(resource_type, providers.Resource):
+ raise ValueError("resource_type must be a subclass of Resource provider")
+
  futures = []
 
  for provider in self.traverse(types=[resource_type]):
@@ -348,6 +352,10 @@ class DynamicContainer(Container):
 
  def shutdown_resources(self, resource_type=providers.Resource):
  """Shutdown all container resources."""
+
+ if not issubclass(resource_type, providers.Resource):
+ raise ValueError("resource_type must be a subclass of Resource provider")
+
  def _independent_resources(resources):
  for resource in resources:
  for other_resource in resources:

tests/unit/containers/instance/test_main_py2_py3.py

@@ -325,6 +325,19 @@ class Container(containers.DeclarativeContainer):
  assert _init2.shutdown_counter == 2
 
 
+def test_init_shutdown_resources_wrong_type() -> None:
+ class Container(containers.DeclarativeContainer):
+ pass
+
+ c = Container()
+
+ with raises(ValueError, match=r"resource_type must be a subclass of Resource provider"):
+ c.init_resources(int) # type: ignore[arg-type]
+
+ with raises(ValueError, match=r"resource_type must be a subclass of Resource provider"):
+ c.shutdown_resources(int) # type: ignore[arg-type]
+
+
 def test_reset_singletons():
  class SubSubContainer(containers.DeclarativeContainer):
  singleton = providers.Singleton(object)