This repository was archived by the owner on Apr 4, 2025. It is now read-only.
CI updates #905
Merged
CI updates #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
filipesilva previously approved these changes May 11, 2018
filipesilva previously approved these changes May 12, 2018
hansl reviewed May 15, 2018
| const c0 = entry.content.readUInt8(0, true); | ||
| const c1 = entry.content.readUInt8(1, true); | ||
| const c2 = entry.content.readUInt8(2, true); | ||
| const c0 = entry.content.length > 0 && entry.content[0]; |
Contributor
There was a problem hiding this comment.
readUInt8 already does that check. What are you trying to fix?
Contributor
There was a problem hiding this comment.
Oh lovely, they removed it in Node 10...
Could you still use readUInt8 please? It's clearer, as Buffer might not be an UInt8Array
hansl approved these changes May 16, 2018
Brocco approved these changes May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.