This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Ng schematics interface #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Brocco suggested changes Jul 12, 2017
Contributor
Brocco left a comment
Brocco left a comment There was a problem hiding this comment.
Can you please add the type option, like the class schematic has defined here: https://github.com/angular/devkit/blob/master/packages/schematics/angular/class/schema.json#L23
And used here: https://github.com/angular/devkit/blob/master/packages/schematics/angular/class/index.ts#L26
And finally used in the file path... from __name__.ts to __name____type__.ts
Contributor Author
| @Brocco Updates are in there now. Also added |
Contributor
| Awesome, please rebase to a single commit with the message "feat(@schematics/angular): Add interface schematic" |
jschwarty force-pushed the ng-schematics-interface branch from d389677 to 1ec41a2 Compare 
jschwarty force-pushed the ng-schematics-interface branch from 1ec41a2 to 995fce3 Compare Brocco approved these changes Jul 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@Brocco can you check this out and let me know if I got everything please? 😄