This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Adding 2 core components #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For now includes a JSON parser that can be used to get an AST, better error messages (with char and line) and will have a loose mode (comments, single-quotes, etc) as well later.
hansl force-pushed the core branch 4 times, most recently from 7ca1ede to 06149c4 Compare Also add a replacement for chalk which could make our life slightly easier (since we dont have to depend on chalk anymore).
filipesilva approved these changes Jun 28, 2017
Contributor
filipesilva left a comment
filipesilva left a comment There was a problem hiding this comment.
LGTM, I don't see anything objectionable.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JSON parser and Logger.