Skip to content

5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 19, 2018
Merged

5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 #1920

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a9cf1ca
feat(afs): Support Firebase 5.5 and Firestore PersistenceSettings
jamesdaniels Oct 17, 2018
d1b4852
chore(): Now that app types are mostly fixed, pull from those
jamesdaniels Oct 17, 2018
32d8a3d
chore(): Changelog entry for 5.1
jamesdaniels Oct 17, 2018
fa92124
chore(): Use PersistenceSettings from interfaces, also fix types in f…
jamesdaniels Oct 17, 2018
cfb92e5
fix(afs): Fix constructor ordering so this isn't a break
jamesdaniels Oct 19, 2018
8901617
feat(functions): Support region configuration via FunctionsRegionToken
jamesdaniels Oct 19, 2018
db31f31
chore(): Changelog entry for region selection
jamesdaniels Oct 19, 2018
ed92c45
chore(): Support Angular 7 without peer dependency warnings
jamesdaniels Oct 19, 2018
4eb34f9
chore(): Changelog for Angular 7
jamesdaniels Oct 19, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(afs): Fix constructor ordering so this isn't a break
  • Loading branch information
@jamesdaniels
jamesdaniels committed Oct 19, 2018
commit cfb92e53d72df0e95d8f42223964c57a0f982016
4 changes: 2 additions & 2 deletions src/firestore/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ export class AngularFirestore {
@Inject(FirebaseOptionsToken) options:FirebaseOptions,
@Optional() @Inject(FirebaseNameOrConfigToken) nameOrConfig:string|FirebaseAppConfig|undefined,
@Optional() @Inject(EnablePersistenceToken) shouldEnablePersistence: boolean,
@Optional() @Inject(PersistenceSettingsToken) persistenceSettings: PersistenceSettings|undefined,
@Optional() @Inject(FirestoreSettingsToken) settings: Settings,
@Inject(PLATFORM_ID) platformId: Object,
zone: NgZone
zone: NgZone,
@Optional() @Inject(PersistenceSettingsToken) persistenceSettings: PersistenceSettings|undefined,
) {
this.scheduler = new FirebaseZoneScheduler(zone, platformId);
this.firestore = zone.runOutsideAngular(() => {
Expand Down