Skip to content

Commit 845be1c

Browse files
rddunlaptorvalds
authored andcommitted
mm: eliminate "expecting prototype" kernel-doc warnings
Fix stray kernel-doc warnings in mm/ due to mis-typed or missing function names. Quietens these kernel-doc warnings: mm/mmu_gather.c:264: warning: expecting prototype for tlb_gather_mmu(). Prototype was for __tlb_gather_mmu() instead mm/oom_kill.c:180: warning: expecting prototype for Check whether unreclaimable slab amount is greater than(). Prototype was for should_dump_unreclaim_slab() instead mm/shuffle.c:155: warning: expecting prototype for shuffle_free_memory(). Prototype was for __shuffle_free_memory() instead Link: https://lkml.kernel.org/r/20210411210642.11362-1-rdunlap@infradead.org Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 06c2aac commit 845be1c

File tree

3 files changed

+22
-13
lines changed

3 files changed

+22
-13
lines changed

mm/mmu_gather.c

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -249,16 +249,6 @@ void tlb_flush_mmu(struct mmu_gather *tlb)
249249
tlb_flush_mmu_free(tlb);
250250
}
251251

252-
/**
253-
* tlb_gather_mmu - initialize an mmu_gather structure for page-table tear-down
254-
* @tlb: the mmu_gather structure to initialize
255-
* @mm: the mm_struct of the target address space
256-
* @fullmm: @mm is without users and we're going to destroy the full address
257-
* space (exit/execve)
258-
*
259-
* Called to initialize an (on-stack) mmu_gather structure for page-table
260-
* tear-down from @mm.
261-
*/
262252
static void __tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm,
263253
bool fullmm)
264254
{
@@ -283,11 +273,30 @@ static void __tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm,
283273
inc_tlb_flush_pending(tlb->mm);
284274
}
285275

276+
/**
277+
* tlb_gather_mmu - initialize an mmu_gather structure for page-table tear-down
278+
* @tlb: the mmu_gather structure to initialize
279+
* @mm: the mm_struct of the target address space
280+
*
281+
* Called to initialize an (on-stack) mmu_gather structure for page-table
282+
* tear-down from @mm.
283+
*/
286284
void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm)
287285
{
288286
__tlb_gather_mmu(tlb, mm, false);
289287
}
290288

289+
/**
290+
* tlb_gather_mmu_fullmm - initialize an mmu_gather structure for page-table tear-down
291+
* @tlb: the mmu_gather structure to initialize
292+
* @mm: the mm_struct of the target address space
293+
*
294+
* In this case, @mm is without users and we're going to destroy the
295+
* full address space (exit/execve).
296+
*
297+
* Called to initialize an (on-stack) mmu_gather structure for page-table
298+
* tear-down from @mm.
299+
*/
291300
void tlb_gather_mmu_fullmm(struct mmu_gather *tlb, struct mm_struct *mm)
292301
{
293302
__tlb_gather_mmu(tlb, mm, true);

mm/oom_kill.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ static bool oom_unkillable_task(struct task_struct *p)
170170
return false;
171171
}
172172

173-
/**
173+
/*
174174
* Check whether unreclaimable slab amount is greater than
175175
* all user memory(LRU pages).
176176
* dump_unreclaimable_slab() could help in the case that

mm/shuffle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ void __meminit __shuffle_zone(struct zone *z)
147147
spin_unlock_irqrestore(&z->lock, flags);
148148
}
149149

150-
/**
151-
* shuffle_free_memory - reduce the predictability of the page allocator
150+
/*
151+
* __shuffle_free_memory - reduce the predictability of the page allocator
152152
* @pgdat: node page data
153153
*/
154154
void __meminit __shuffle_free_memory(pg_data_t *pgdat)

0 commit comments

Comments
 (0)