Skip to content

Commit dd89c50

Browse files
authored
Fix various issues and inconsistencies in the Remote Config ref docs. (firebase#4964)
1 parent 1588712 commit dd89c50

File tree

6 files changed

+20
-25
lines changed

6 files changed

+20
-25
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,12 @@
4848
import org.json.JSONObject;
4949

5050
/**
51-
* Entry point for the Firebase Remote Config (FRC) API.
51+
* Entry point for the Firebase Remote Config API.
5252
*
5353
* <p>Callers should first get the singleton object using {@link #getInstance()}, and then call
54-
* operations on that singleton object. The singleton contains the complete set of FRC parameter
55-
* values available to your app. The singleton also stores values fetched from the FRC Server until
56-
* they are made available for use with a call to {@link #activate()}.
57-
*
58-
* @author Miraziz Yusupov
54+
* operations on that singleton object. The singleton contains the complete set of Remote Config
55+
* parameter values available to your app. The singleton also stores values fetched from the Remote
56+
* Config Server until they are made available for use with a call to {@link #activate()}.
5957
*/
6058
public class FirebaseRemoteConfig {
6159
// -------------------------------------------------------------------------------
@@ -557,8 +555,8 @@ public Task<Void> reset() {
557555
* re-use the same connection to the backend.
558556
*
559557
* <p>Note: Real-time Remote Config requires the Firebase Remote Config Realtime API. See the <a
560-
* href="https://firebase.google.com/docs/remote-config/get-started#add-real-time-listener">Remote
561-
* Config Get Started </a> guide to enable the API.
558+
* href="https://firebase.google.com/docs/remote-config/get-started?platform=android#add-real-time-listener">Remote
559+
* Config Get Started</a> guide to enable the API.
562560
*
563561
* @param configUpdateListener A {@link ConfigUpdateListener} that can be used to respond to
564562
* config updates when they're fetched.

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientException.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
/**
2121
* A Firebase Remote Config internal issue that isn't caused by an interaction with the Firebase
2222
* Remote Config server.
23-
*
24-
* @author Miraziz Yusupov
2523
*/
2624
public class FirebaseRemoteConfigClientException extends FirebaseRemoteConfigException {
2725
/** Creates a Firebase Remote Config client exception with the given message. */
@@ -36,8 +34,8 @@ public FirebaseRemoteConfigClientException(
3634
}
3735

3836
/**
39-
* Creates a Firebase Remote Config client exception with the given message and
40-
* FirebaseRemoteConfigException code.
37+
* Creates a Firebase Remote Config client exception with the given message and {@code
38+
* FirebaseRemoteConfigException} code.
4139
*/
4240
public FirebaseRemoteConfigClientException(@NonNull String detailMessage, @NonNull Code code) {
4341
super(detailMessage, code);

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigException.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ public int value() {
7575
}
7676
}
7777

78+
/**
79+
* Gets the {@link Code} representing the type of exception.
80+
*
81+
* @return A {@link Code} representing the type of exception.
82+
*/
7883
@NonNull
7984
public Code getCode() {
8085
return code;

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import androidx.annotation.NonNull;
1818

19-
/** Wraps the current state of the FirebaseRemoteConfig singleton object. */
19+
/** Wraps the current state of the {@link FirebaseRemoteConfig} singleton object. */
2020
public interface FirebaseRemoteConfigInfo {
2121
/**
2222
* Gets the timestamp (milliseconds since epoch) of the last successful fetch, regardless of
@@ -38,7 +38,7 @@ public interface FirebaseRemoteConfigInfo {
3838
int getLastFetchStatus();
3939

4040
/**
41-
* Gets the current settings of the FirebaseRemoteConfig singleton object.
41+
* Gets the current settings of the {@link FirebaseRemoteConfig} singleton object.
4242
*
4343
* @return A {@link FirebaseRemoteConfigSettings} object indicating the current settings.
4444
*/

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigServerException.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
/**
2222
* A Firebase Remote Config internal issue caused by an interaction with the Firebase Remote Config
2323
* server.
24-
*
25-
* @author Miraziz Yusupov
2624
*/
2725
public class FirebaseRemoteConfigServerException extends FirebaseRemoteConfigException {
2826
private final int httpStatusCode;

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigSettings.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@
1919

2020
import androidx.annotation.NonNull;
2121

22-
/**
23-
* Wraps the settings for {@link FirebaseRemoteConfig} operations.
24-
*
25-
* @author Lucas Png
26-
*/
22+
/** Wraps the settings for {@link FirebaseRemoteConfig} operations. */
2723
public class FirebaseRemoteConfigSettings {
2824
private final long fetchTimeoutInSeconds;
2925
private final long minimumFetchInterval;
@@ -37,7 +33,7 @@ private FirebaseRemoteConfigSettings(Builder builder) {
3733
* Returns the fetch timeout in seconds.
3834
*
3935
* <p>The timeout specifies how long the client should wait for a connection to the Firebase
40-
* Remote Config servers.
36+
* Remote Config server.
4137
*/
4238
public long getFetchTimeoutInSeconds() {
4339
return fetchTimeoutInSeconds;
@@ -48,7 +44,7 @@ public long getMinimumFetchIntervalInSeconds() {
4844
return minimumFetchInterval;
4945
}
5046

51-
/** Constructs a builder initialized with the current FirebaseRemoteConfigSettings. */
47+
/** Constructs a builder initialized with the current {@link FirebaseRemoteConfigSettings}. */
5248
@NonNull
5349
public FirebaseRemoteConfigSettings.Builder toBuilder() {
5450
FirebaseRemoteConfigSettings.Builder frcBuilder = new FirebaseRemoteConfigSettings.Builder();
@@ -68,7 +64,7 @@ public static class Builder {
6864
* servers in seconds.
6965
*
7066
* <p>A fetch call will fail if it takes longer than the specified timeout to connect to or read
71-
* from the Remote Config servers.
67+
* from the Remote Config server.
7268
*
7369
* @param duration Timeout duration in seconds. Should be a non-negative number.
7470
*/
@@ -109,7 +105,7 @@ public Builder setMinimumFetchIntervalInSeconds(long duration) {
109105
* Returns the fetch timeout in seconds.
110106
*
111107
* <p>The timeout specifies how long the client should wait for a connection to the Firebase
112-
* Remote Config servers.
108+
* Remote Config server.
113109
*/
114110
public long getFetchTimeoutInSeconds() {
115111
return fetchTimeoutInSeconds;

0 commit comments

Comments
 (0)