Slice class updated: properties are protected now.

Author: Smoren

src/Structs/NormalizedSlice.php

@@ -9,37 +9,53 @@
 /**
  * Represents a normalized slice definition with start, end, and step values.
  *
- * @property-read int $start The start index of the normalized slice.
- * @property-read int $end The end index of the normalized slice.
- * @property-read int $step The step size for selecting elements in the normalized slice.
- *
  * @implements \IteratorAggregate<int, int>
  */
 class NormalizedSlice extends Slice implements \Countable, \IteratorAggregate
 {
  /**
- * @var int|null The start index of the normalized slice.
+ * Creates a new NormalizedSlice instance with optional start, end, and step values.
+ *
+ * @param int|null $start The start index of the slice range.
+ * @param int|null $end The end index of the slice range.
+ * @param int|null $step The step size for selecting elements in the slice range.
  */
- public ?int $start; // TODO int, not int|null, but phpstan do not like it.
+ public function __construct(int $start = null, int $end = null, int $step = null)
+ {
+ parent::__construct($start, $end, $step);
+ }
+
  /**
- * @var int|null The end index of the normalized slice.
+ * Getter for the start index of the normalized slice.
+ *
+ * @return int
  */
- public ?int $end;
+ public function getStart(): int
+ {
+ /** @var int */
+ return $this->start;
+ }
+
  /**
- * @var int|null The step size for selecting elements in the normalized slice.
+ * Getter for the stop index of the normalized slice.
+ *
+ * @return int
  */
- public ?int $step;
+ public function getEnd(): int
+ {
+ /** @var int */
+ return $this->end;
+ }
 
  /**
- * Creates a new NormalizedSlice instance with optional start, end, and step values.
+ * Getter for the step of the normalized slice.
  *
- * @param int|null $start The start index of the slice range.
- * @param int|null $end The end index of the slice range.
- * @param int|null $step The step size for selecting elements in the slice range.
+ * @return int
  */
- public function __construct(int $start = null, int $end = null, int $step = null)
+ public function getStep(): int
  {
- parent::__construct($start, $end, $step);
+ /** @var int */
+ return $this->step;
  }
 
  /**

src/Structs/Slice.php

@@ -10,25 +10,21 @@
 
 /**
  * Represents a slice definition for selecting a range of elements.
- *
- * @property-read int|null $start The start index of the slice range.
- * @property-read int|null $end The end index of the slice range.
- * @property-read int|null $step The step size for selecting elements in the slice range.
  */
 class Slice
 {
  /**
  * @var int|null The start index of the slice range.
  */
- public ?int $start;
+ protected ?int $start;
  /**
  * @var int|null The end index of the slice range.
  */
- public ?int $end;
+ protected ?int $end;
  /**
  * @var int|null The step size for selecting elements in the slice range.
  */
- public ?int $step;
+ protected ?int $step;
 
  /**
  * Converts a slice string or Slice object into a Slice instance.
@@ -142,6 +138,36 @@ public function __construct(?int $start = null, ?int $end = null, ?int $step = n
  $this->step = $step;
  }
 
+ /**
+ * Getter for the start index of the normalized slice.
+ *
+ * @return int|null
+ */
+ public function getStart(): ?int
+ {
+ return $this->start;
+ }
+
+ /**
+ * Getter for the stop index of the normalized slice.
+ *
+ * @return int|null
+ */
+ public function getEnd(): ?int
+ {
+ return $this->end;
+ }
+
+ /**
+ * Getter for the step of the normalized slice.
+ *
+ * @return int|null
+ */
+ public function getStep(): ?int
+ {
+ return $this->step;
+ }
+
  /**
  * Normalizes the slice parameters based on the container length.
  *

tests/unit/Structs/SliceTest.php

@@ -48,9 +48,9 @@ public function testToSlice($input, array $expected)
  $actual = Slice::toSlice($input);
  $expectedSlice = new Slice(...$expected);
 
- $this->assertSame($expectedSlice->start, $actual->start);
- $this->assertSame($expectedSlice->end, $actual->end);
- $this->assertSame($expectedSlice->step, $actual->step);
+ $this->assertSame($expectedSlice->getStart(), $actual->getStart());
+ $this->assertSame($expectedSlice->getEnd(), $actual->getEnd());
+ $this->assertSame($expectedSlice->getStep(), $actual->getStep());
  }
 
  /**