Skip to content
This repository was archived by the owner on Jan 29, 2022. It is now read-only.

Commit 1d1e2f0

Browse files
authored
Merge pull request #29 from SimonGolms/dev
release
2 parents 4e46d47 + ad63b73 commit 1d1e2f0

File tree

3 files changed

+24
-30
lines changed

3 files changed

+24
-30
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"@angular/platform-browser": "~8.2.14",
6060
"@angular/platform-browser-dynamic": "~8.2.14",
6161
"@angular/router": "~8.2.14",
62-
"@ionic/angular": "^4.11.7",
62+
"@ionic/angular": "^4.11.10",
6363
"rxjs": "~6.5.3",
6464
"tslib": "^1.10.0",
6565
"zone.js": "~0.9.1"

projects/ngx-ionic-image-viewer/src/lib/viewer-modal/viewer-modal.component.ts

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ModalController, IonSlides } from '@ionic/angular';
44
@Component({
55
selector: 'ion-viewer-modal',
66
templateUrl: './viewer-modal.component.html',
7-
styleUrls: ['./viewer-modal.component.scss']
7+
styleUrls: ['./viewer-modal.component.scss'],
88
})
99
export class ViewerModalComponent implements OnInit {
1010
// tslint:disable: no-inferrable-types
@@ -24,8 +24,8 @@ export class ViewerModalComponent implements OnInit {
2424
centeredSlides: true,
2525
passiveListeners: false,
2626
zoom: {
27-
enabled: true
28-
}
27+
enabled: true,
28+
},
2929
};
3030

3131
options = {};
@@ -43,7 +43,7 @@ export class ViewerModalComponent implements OnInit {
4343
restraint: 100, // maximum distance allowed at the same time in perpendicular direction
4444
allowedTime: 500, // maximum time allowed to travel that distance
4545
elapsedTime: 0,
46-
startTime: 0
46+
startTime: 0,
4747
};
4848

4949
@ViewChild('sliderRef', { static: true }) slides: IonSlides;
@@ -63,7 +63,7 @@ export class ViewerModalComponent implements OnInit {
6363
* Hint: Comment in '<ion-slide>' in component
6464
*/
6565
const swiper = await this.slides.getSwiper();
66-
swiper.appendSlide(`<ion-slide><img alt="${this.alt}" src="${this.src}" (error)="(onError($event))"/></ion-slide>`);
66+
swiper.appendSlide(`<ion-slide><img alt="${this.alt}" src="${this.src}" onerror="this.src='${this.srcFallback}'"/></ion-slide>`);
6767
}
6868

6969
setStyle() {
@@ -109,14 +109,14 @@ export class ViewerModalComponent implements OnInit {
109109
}
110110

111111
const el = document.querySelector('ion-modal');
112-
el.addEventListener('mousedown', event => this.swipeStart(event), true);
113-
el.addEventListener('mousemove', event => this.swipeMove(event), true);
114-
el.addEventListener('mouseup', event => this.swipeEnd(event), true);
115-
el.addEventListener('touchstart', event => this.swipeStart(event), true);
116-
el.addEventListener('touchmove', event => this.swipeMove(event), true);
117-
el.addEventListener('touchend', event => this.swipeEnd(event), true);
118-
119-
this.modalController.getTop().then(modal => {
112+
el.addEventListener('mousedown', (event) => this.swipeStart(event), true);
113+
el.addEventListener('mousemove', (event) => this.swipeMove(event), true);
114+
el.addEventListener('mouseup', (event) => this.swipeEnd(event), true);
115+
el.addEventListener('touchstart', (event) => this.swipeStart(event), true);
116+
el.addEventListener('touchmove', (event) => this.swipeMove(event), true);
117+
el.addEventListener('touchend', (event) => this.swipeEnd(event), true);
118+
119+
this.modalController.getTop().then((modal) => {
120120
modal.onWillDismiss().then(() => {
121121
document.removeEventListener('mousedown', this.swipeStart, true);
122122
document.removeEventListener('mousemove', this.swipeMove, true);
@@ -138,7 +138,7 @@ export class ViewerModalComponent implements OnInit {
138138
distance: 0,
139139
startX: pageX,
140140
startY: pageY,
141-
startTime: new Date().getTime()
141+
startTime: new Date().getTime(),
142142
};
143143
}
144144

@@ -169,7 +169,7 @@ export class ViewerModalComponent implements OnInit {
169169
direction,
170170
distance,
171171
distanceX,
172-
distanceY
172+
distanceY,
173173
};
174174
event.preventDefault();
175175
}
@@ -196,20 +196,14 @@ export class ViewerModalComponent implements OnInit {
196196
this.swipeState = {
197197
...this.swipeState,
198198
phase: 'end',
199-
swipeType
199+
swipeType,
200200
};
201201

202202
if (swipeType === 'down') {
203203
return this.closeModal();
204204
}
205205
}
206206

207-
onError(error) {
208-
if (this.srcFallback) {
209-
this.src = this.srcFallback;
210-
}
211-
}
212-
213207
closeModal() {
214208
this.modalController.dismiss();
215209
}

0 commit comments

Comments
 (0)