uncomment "cyclability" weight name #7043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kdziurman approved these changes Sep 30, 2024
Member
| From the introduction of the concept 279f8aabfb#diff-c4b120b8978b0193746a4accb230bf085b89bca0fdda9f17920e056ddaee820fR58 I see this PR as a possible breaking change. Nevertheless can can still use |
| This PR seems to be stale. Is it still relevant? |
Member
| For context: This was not chosen as the default because it roughly x1.5 the memory usage since you need separate weight and duration values. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
It looks like in
profile/bicycle.luatheweight_namein properties was unintentionally commented outWithout it set to
cyclabilitythesafety_checkis committed when using this profile. Turns' weights are also calculated differentlyTasklist
Requirements / Relations