Guard against incorrect use of resources associated with a connection #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We already check for attempts to use connection methods after the connection has been returned to the pool. This adds a similar check for objects associated with the connection: prepared statements and cursors. Issue: #190.
1st1 reviewed Sep 12, 2017
asyncpg/connresource.py Outdated
| | ||
| def __init__(self, connection): | ||
| self._connection = connection | ||
| self._con_release_ctr = getattr(connection, '_pool_release_ctr', None) |
1st1 reviewed Sep 12, 2017
| | ||
| # Invalidate external references to the connection. | ||
| self._con._pool_release_ctr += 1 | ||
| self._con._on_release() |
Member
There was a problem hiding this comment.
Inc '_pool_release_ctr' in '_on_release'?
elprans force-pushed the connvalidity branch from 110e480 to 419f815 Compare 1st1 approved these changes Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.