Fix compiler warnings

Author: elprans

asyncpg/pgproto

@@ -146,6 +146,8 @@ cdef multirange_encode(ConnectionSettings settings, WriteBuffer buf,
  encode_func_ex encoder, const void *encoder_arg):
  cdef:
  WriteBuffer elem_data
+ ssize_t elem_data_len
+ ssize_t elem_count
 
  if not isinstance(obj, SequenceABC):
  raise TypeError(
@@ -157,10 +159,20 @@ cdef multirange_encode(ConnectionSettings settings, WriteBuffer buf,
  for elem in obj:
  range_encode(settings, elem_data, elem, elem_oid, encoder, encoder_arg)
 
+ elem_count = len(obj)
+ if elem_count > INT32_MAX:
+ raise OverflowError(f'too many elements in multirange value')
+
+ elem_data_len = elem_data.len()
+ if elem_data_len > INT32_MAX - 4:
+ raise OverflowError(
+ f'size of encoded multirange datum exceeds the maximum allowed'
+ f' {INT32_MAX - 4} bytes')
+
  # Datum length
- buf.write_int32(4 + elem_data.len())
+ buf.write_int32(4 + <int32_t>elem_data_len)
  # Number of elements in multirange
- buf.write_int32(len(obj))
+ buf.write_int32(<int32_t>elem_count)
  buf.write_buffer(elem_data)
 
 

asyncpg/protocol/codecs/range.pyx

@@ -151,7 +151,7 @@ cdef class PreparedStatementState:
  writer.write_int16(self.args_num)
  for idx in range(self.args_num):
  codec = <Codec>(self.args_codecs[idx])
- writer.write_int16(codec.format)
+ writer.write_int16(<int16_t>codec.format)
  else:
  # All arguments are in binary format
  writer.write_int32(0x00010001)
@@ -203,7 +203,7 @@ cdef class PreparedStatementState:
  writer.write_int16(self.cols_num)
  for idx in range(self.cols_num):
  codec = <Codec>(self.rows_codecs[idx])
- writer.write_int16(codec.format)
+ writer.write_int16(<int16_t>codec.format)
  else:
  # All columns are in binary format
  writer.write_int32(0x00010001)

asyncpg/protocol/prepared_stmt.pyx

@@ -38,7 +38,7 @@ from asyncpg.protocol cimport record
 
 from libc.stdint cimport int8_t, uint8_t, int16_t, uint16_t, \
  int32_t, uint32_t, int64_t, uint64_t, \
- UINT32_MAX
+ INT32_MAX, UINT32_MAX
 
 from asyncpg.exceptions import _base as apg_exc_base
 from asyncpg import compat

asyncpg/protocol/protocol.pyx

@@ -63,7 +63,7 @@ ApgRecord_New(PyTypeObject *type, PyObject *desc, Py_ssize_t size)
  return PyErr_NoMemory();
  }
  o = (ApgRecordObject *)type->tp_alloc(type, size);
- if (!_ApgObject_GC_IS_TRACKED(o)) {
+ if (!_ApgObject_GC_IS_TRACKED((PyObject *)o)) {
  PyErr_SetString(
  PyExc_TypeError,
  "record subclass is not tracked by GC"