Address RTDB Lint violations (firebase#1866)

Author: schmidt-sebastian

firebase-database/src/main/java/com/google/firebase/database/DatabaseError.java

@@ -19,6 +19,7 @@
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.util.HashMap;
+import java.util.Locale;
 import java.util.Map;
 
 /**
@@ -164,7 +165,7 @@ public static DatabaseError fromCode(int code) {
  */
  @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
  public static DatabaseError fromStatus(String status, String reason, String details) {
- Integer code = errorCodes.get(status.toLowerCase());
+ Integer code = errorCodes.get(status.toLowerCase(Locale.US));
  if (code == null) {
  code = UNKNOWN_ERROR;
  }

firebase-database/src/main/java/com/google/firebase/database/Query.java

@@ -362,7 +362,7 @@ private Query startAt(Node node, String key) {
  QueryParams newParams = params.startAt(node, childKey);
  validateLimit(newParams);
  validateQueryEndpoints(newParams);
- assert newParams.isValid();
+ hardAssert(newParams.isValid());
  return new Query(repo, path, newParams, orderByCalled);
  }
 
@@ -460,7 +460,7 @@ private Query endAt(Node node, String key) {
  QueryParams newParams = params.endAt(node, childKey);
  validateLimit(newParams);
  validateQueryEndpoints(newParams);
- assert newParams.isValid();
+ hardAssert(newParams.isValid());
  return new Query(repo, path, newParams, orderByCalled);
  }
 

firebase-database/src/main/java/com/google/firebase/database/android/SqlPersistenceStorageEngine.java

@@ -171,7 +171,8 @@ public void onCreate(SQLiteDatabase db) {
 
  @Override
  public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
- assert newVersion == DATABASE_VERSION : "Why is onUpgrade() called with a different version?";
+ hardAssert(
+ newVersion == DATABASE_VERSION, "Why is onUpgrade() called with a different version?");
  if (oldVersion <= 1) {
  // Leave old writes table.
 
@@ -1036,12 +1037,12 @@ private static String pathToKey(Path path) {
  }
 
  private static String pathPrefixStartToPrefixEnd(String prefix) {
- assert prefix.endsWith("/") : "Path keys must end with a '/'";
+ hardAssert(prefix.endsWith("/"), "Path keys must end with a '/'");
  return prefix.substring(0, prefix.length() - 1) + (char) ('/' + 1);
  }
 
  private static String buildAncestorWhereClause(Path path, String[] arguments) {
- assert arguments.length >= path.size() + 1;
+ hardAssert(arguments.length >= path.size() + 1);
  int count = 0;
  StringBuilder whereClause = new StringBuilder("(");
  while (!path.isEmpty()) {

firebase-database/src/main/java/com/google/firebase/database/connection/PersistentConnectionImpl.java

@@ -1010,8 +1010,9 @@ private void putInternal(
  }
 
  private void sendPut(final long putId) {
- assert canSendWrites()
- : "sendPut called when we can't send writes (we're disconnected or writes are paused).";
+ hardAssert(
+ canSendWrites(),
+ "sendPut called when we can't send writes (we're disconnected or writes are paused).");
  final OutstandingPut put = outstandingPuts.get(putId);
  final RequestResultCallback onComplete = put.getOnComplete();
  final String action = put.getAction();

firebase-database/src/main/java/com/google/firebase/database/core/CompoundWrite.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.database.core;
 
+import static com.google.firebase.database.core.utilities.Utilities.hardAssert;
+
 import com.google.firebase.database.core.utilities.ImmutableTree;
 import com.google.firebase.database.snapshot.ChildKey;
 import com.google.firebase.database.snapshot.NamedNode;
@@ -227,7 +229,7 @@ private Node applySubtreeWrite(Path relativePath, ImmutableTree<Node> writeTree,
  if (childKey.isPriorityChildName()) {
  // Apply priorities at the end so we don't update priorities for either empty nodes or
  // forget to apply priorities to empty nodes that are later filled
- assert childTree.getValue() != null : "Priority writes must always be leaf nodes";
+ hardAssert(childTree.getValue() != null, "Priority writes must always be leaf nodes");
  priorityWrite = childTree.getValue();
  } else {
  node = applySubtreeWrite(relativePath.child(childKey), childTree, node);

firebase-database/src/main/java/com/google/firebase/database/core/EventRegistration.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.database.core;
 
+import static com.google.firebase.database.core.utilities.Utilities.hardAssert;
+
 import com.google.firebase.database.DatabaseError;
 import com.google.firebase.database.annotations.NotNull;
 import com.google.firebase.database.core.view.Change;
@@ -56,8 +58,8 @@ public boolean isZombied() {
  }
 
  public void setOnZombied(EventRegistrationZombieListener listener) {
- assert !isZombied();
- assert this.listener == null;
+ hardAssert(!isZombied());
+ hardAssert(this.listener == null);
  this.listener = listener;
  }
 

firebase-database/src/main/java/com/google/firebase/database/core/Path.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.database.core;
 
+import static com.google.firebase.database.core.utilities.Utilities.hardAssert;
+
 import com.google.firebase.database.DatabaseException;
 import com.google.firebase.database.snapshot.ChildKey;
 import java.util.ArrayList;
@@ -51,7 +53,7 @@ public Path(ChildKey... segments) {
  this.start = 0;
  this.end = segments.length;
  for (ChildKey name : segments) {
- assert name != null : "Can't construct a path with a null value!";
+ hardAssert(name != null, "Can't construct a path with a null value!");
  }
  }
 

firebase-database/src/main/java/com/google/firebase/database/core/Repo.java

@@ -642,7 +642,7 @@ public void addEventCallback(@NotNull EventRegistration eventRegistration) {
  }
 
  public void keepSynced(QuerySpec query, boolean keep) {
- assert query.getPath().isEmpty() || !query.getPath().getFront().equals(Constants.DOT_INFO);
+ hardAssert(query.getPath().isEmpty() || !query.getPath().getFront().equals(Constants.DOT_INFO));
 
  serverSyncTree.keepSynced(query, keep);
  }
@@ -920,7 +920,7 @@ private void sendReadyTransactions(Tree<List<TransactionData>> node) {
  List<TransactionData> queue = node.getValue();
  if (queue != null) {
  queue = buildTransactionQueue(node);
- assert queue.size() > 0; // Sending zero length transaction queue
+ hardAssert(queue.size() > 0); // Sending zero length transaction queue
 
  Boolean allRun = true;
  for (TransactionData transaction : queue) {
@@ -959,8 +959,9 @@ private void sendTransactionQueue(final List<TransactionData> queue, final Path
  }
 
  for (TransactionData txn : queue) {
- assert txn.status
- == TransactionStatus.RUN; // sendTransactionQueue: items in queue should all be run.'
+ hardAssert(
+ txn.status
+ == TransactionStatus.RUN); // sendTransactionQueue: items in queue should all be run.'
  txn.status = TransactionStatus.SENT;
  txn.retryCount++;
  Path relativePath = Path.getRelative(path, txn.path);
@@ -1116,7 +1117,7 @@ private void rerunTransactionQueue(List<TransactionData> queue, Path path) {
  DatabaseError abortReason = null;
  List<Event> events = new ArrayList<Event>();
 
- assert relativePath != null; // rerunTransactionQueue: relativePath should not be null.
+ hardAssert(relativePath != null); // rerunTransactionQueue: relativePath should not be null.
 
  if (transaction.status == TransactionStatus.NEEDS_ABORT) {
  abortTransaction = true;
@@ -1321,14 +1322,15 @@ private void abortTransactionsAtNode(Tree<List<TransactionData>> node, int reaso
  if (transaction.status == TransactionStatus.SENT_NEEDS_ABORT) {
  // No-op. Already marked
  } else if (transaction.status == TransactionStatus.SENT) {
- assert lastSent == i - 1; // All SENT items should be at beginning of queue.
+ hardAssert(lastSent == i - 1); // All SENT items should be at beginning of queue.
  lastSent = i;
  // Mark transaction for abort when it comes back.
  transaction.status = TransactionStatus.SENT_NEEDS_ABORT;
  transaction.abortReason = abortError;
  } else {
- assert transaction.status
- == TransactionStatus.RUN; // Unexpected transaction status in abort
+ hardAssert(
+ transaction.status
+ == TransactionStatus.RUN); // Unexpected transaction status in abort
  // We can abort this immediately.
  removeEventCallback(
  new ValueEventRegistration(

firebase-database/src/main/java/com/google/firebase/database/core/SyncPoint.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.database.core;
 
+import static com.google.firebase.database.core.utilities.Utilities.hardAssert;
+
 import com.google.firebase.database.DatabaseError;
 import com.google.firebase.database.annotations.NotNull;
 import com.google.firebase.database.annotations.Nullable;
@@ -98,7 +100,7 @@ public List<DataEvent> applyOperation(
  QueryParams queryParams = operation.getSource().getQueryParams();
  if (queryParams != null) {
  View view = this.views.get(queryParams);
- assert view != null;
+ hardAssert(view != null);
  return applyOperationToView(view, operation, writesCache, optCompleteServerCache);
  } else {
  List<DataEvent> events = new ArrayList<DataEvent>();

firebase-database/src/main/java/com/google/firebase/database/core/SyncTree.java

@@ -348,11 +348,11 @@ public List<? extends Event> applyTaggedRangeMerges(
  Path path, List<RangeMerge> rangeMerges, Tag tag) {
  QuerySpec query = queryForTag(tag);
  if (query != null) {
- assert path.equals(query.getPath());
+ hardAssert(path.equals(query.getPath()));
  SyncPoint syncPoint = syncPointTree.get(query.getPath());
- assert syncPoint != null : "Missing sync point for query tag that we're tracking";
+ hardAssert(syncPoint != null, "Missing sync point for query tag that we're tracking");
  View view = syncPoint.viewForQuery(query);
- assert view != null : "Missing view for query tag that we're tracking";
+ hardAssert(view != null, "Missing view for query tag that we're tracking");
  Node serverNode = view.getServerCache();
  for (RangeMerge merge : rangeMerges) {
  serverNode = merge.applyTo(serverNode);
@@ -400,7 +400,7 @@ public List<? extends Event> call() {
  private List<? extends Event> applyTaggedOperation(QuerySpec query, Operation operation) {
  Path queryPath = query.getPath();
  SyncPoint syncPoint = syncPointTree.get(queryPath);
- assert syncPoint != null : "Missing sync point for query tag that we're tracking";
+ hardAssert(syncPoint != null, "Missing sync point for query tag that we're tracking");
  WriteTreeRef writesCache = pendingWriteTree.childWrites(queryPath);
  return syncPoint.applyOperation(operation, writesCache, /*serverCache*/ null);
  }
@@ -542,7 +542,8 @@ public List<? extends Event> call() {
  boolean viewAlreadyExists = syncPoint.viewExistsForQuery(query);
  if (!viewAlreadyExists && !query.loadsAllData()) {
  // We need to track a tag for this query
- assert !queryToTagMap.containsKey(query) : "View does not exist but we have a tag";
+ hardAssert(
+ !queryToTagMap.containsKey(query), "View does not exist but we have a tag");
  Tag tag = getNextQueryTag();
  queryToTagMap.put(query, tag);
  tagToQueryMap.put(tag, query);
@@ -663,7 +664,7 @@ public List<Event> call() {
  } else {
  for (QuerySpec queryToRemove : removed) {
  Tag tag = tagForQuery(queryToRemove);
- assert tag != null;
+ hardAssert(tag != null);
  listenProvider.stopListening(queryForListening(queryToRemove), tag);
  }
  }
@@ -770,7 +771,7 @@ private void removeTags(List<QuerySpec> queries) {
  if (!removedQuery.loadsAllData()) {
  // We should have a tag for this
  Tag tag = this.tagForQuery(removedQuery);
- assert tag != null;
+ hardAssert(tag != null);
  this.queryToTagMap.remove(removedQuery);
  this.tagToQueryMap.remove(tag);
  }
@@ -798,8 +799,9 @@ private void setupListener(QuerySpec query, View view) {
  // The root of this subtree has our query. We're here because we definitely need to send a
  // listen for that, but we may need to shadow other listens as well.
  if (tag != null) {
- assert !subtree.getValue().hasCompleteView()
- : "If we're adding a query, it shouldn't be shadowed";
+ hardAssert(
+ !subtree.getValue().hasCompleteView(),
+ "If we're adding a query, it shouldn't be shadowed");
  } else {
  // Shadow everything at or below this location, this is a default listener.
  subtree.foreach(