Skip to content

Commit 0e93870

Browse files
authored
Check for user ID file before trying to read it (firebase#1635)
The user ID file will be missing if no user ID was set, so check if it exists before trying to read from it to avoid unnecessary error logging. Fixes one of the prevalent issues in firebase#1559
1 parent 95397ca commit 0e93870

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/persistence/CrashlyticsReportPersistence.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,13 @@ private void synthesizeReport(@NonNull File sessionDirectory, long sessionEndTim
305305
}
306306

307307
String userId = null;
308-
try {
309-
userId = readTextFile(new File(sessionDirectory, USER_FILE_NAME));
310-
} catch (IOException e) {
311-
Logger.getLogger().d("Could not read user ID file in " + sessionDirectory.getName(), e);
308+
final File userIdFile = new File(sessionDirectory, USER_FILE_NAME);
309+
if (userIdFile.isFile()) {
310+
try {
311+
userId = readTextFile(userIdFile);
312+
} catch (IOException e) {
313+
Logger.getLogger().d("Could not read user ID file in " + sessionDirectory.getName(), e);
314+
}
312315
}
313316

314317
final File reportFile = new File(sessionDirectory, REPORT_FILE_NAME);

0 commit comments

Comments
 (0)