Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(209)

Issue 98290044: Graph with all median lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by mgl
Modified:
11 years, 5 months ago
Reviewers:
pmeenan
Visibility:
Public.

Description

Graph with all median lines

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M www/graph_page_data.php View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2
pmeenan
I think it makes more sense to always have 2 lines. One for the run ...
11 years, 6 months ago (2014-05-16 13:22:29 UTC) #1
mgl
11 years, 5 months ago (2014-05-19 19:57:30 UTC) #2
On 2014/05/16 13:22:29, pmeenan wrote: > I think it makes more sense to always have 2 lines. One for the run that > matches the median metric and one for the median value of the current metric > (I'd make the median value the same color and the value of the median run a > different color). That way it's always consistent. I'm concerned that having two median lines for each of the first and repeat views may make the graph look cluttered and difficult to read. And although I do like the idea of looking at multiple metrics for the same run, a user may not necessarily be interested in the median run for a particular "default" metric like page load time. I think we should at least identify more clearly what metric is being used for the median run if we're going to show the median run line prominently by default. I'd also like a good way to show overall median data if possible on the main results page view (http://latencylab/result/140519_ST_21V/?medianMetric=loadTime). We could have another box for overall medians, but I'm afraid that may be confusing as well. What if we have a drop down box for median run metric selection, with one option being 'median run for metric shown', for both the graph_page_data.php and result.inc?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b