Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(716)

Issue 8696045: SkPictureRecord::getSize()

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by TomH
Modified:
12 years, 5 months ago
Reviewers:
nduca, DerekS, reed1
CC:
enne, VangelisK, reveman
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/chromium/issues/detail?id=230419 This has its own issues - in order to be minimally invasive, I made validate() non-const and did the size accumulation there - but I think it's a more promising direction to go as far as both initial effort and maintainability. Needs tests, and since there was disagreement yesterday about how to pursue this (compare to https://codereview.appspot.com/8704043/), want feedback from the Skia team before I polish this for full review.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M src/core/SkPathHeap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPathHeap.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 4 chunks +7 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 6 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4
TomH
Alternate implementation
12 years, 6 months ago (2013-04-12 12:31:44 UTC) #1
nduca
Ping. Any progress? This is very useful.
12 years, 5 months ago (2013-05-21 17:46:25 UTC) #2
reed1
How is this CL's api actually exposed to the client?
12 years, 5 months ago (2013-05-21 18:26:47 UTC) #3
TomH
12 years, 5 months ago (2013-05-21 18:56:13 UTC) #4
Nat, no progress, none expected soon. Details out-of-band. Mike, I was still trying to figure out how best to gather the data internally before worrying about the external API.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b