code review 8248044: doc: use the already defined GOPATH in PATH

doc: use the already defined GOPATH in PATH

[frou, 2013-04-04 04:09:58]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

[adg, 2013-04-04 05:32:55]

LGTM 

[adg, 2013-04-04 05:36:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=e77430da3316 *** doc: use the already defined GOPATH in PATH R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/8248044 Committer: Andrew Gerrand <adg@golang.org>

[ioe, 2013-04-05 07:38:11]

NLGTM It breaks mysteriously later leading to increased support load. Details see below. https://codereview.appspot.com/8248044/diff/5001/doc/code.html File doc/code.html (right): https://codereview.appspot.com/8248044/diff/5001/doc/code.html#newcode128 doc/code.html:128: $ <b>export PATH=$PATH:$GOPATH/bin</b> This will only work in the example. But will mysteriously break, if the user starts adding more entries to the GOPATH. Esp. since go writes only to the FIRST component of it and export PATH=$PATH:$GOPATH/bin will only add the binary location of the LAST component to the path. The user will not see his just compiled binaries. So please remove this optimization.

[frou, 2013-04-05 10:08:44]

Fair enough. I suppose even when GOPATH only has one element, it should still strictly be thought of as a list. I proposed the change because people are liable to reorganise their home directory, and in that case it's nice to only have a single location that needs updating. On 2013/04/05 07:38:11, ioe wrote: > NLGTM > > It breaks mysteriously later leading to increased support load. Details see > below. > > https://codereview.appspot.com/8248044/diff/5001/doc/code.html > File doc/code.html (right): > > https://codereview.appspot.com/8248044/diff/5001/doc/code.html#newcode128 > doc/code.html:128: $ <b>export PATH=$PATH:$GOPATH/bin</b> > This will only work in the example. But will mysteriously break, if the user > starts adding more entries to the GOPATH. > > Esp. since go writes only to the FIRST component of it and export > PATH=$PATH:$GOPATH/bin will only add the binary location of the LAST component > to the path. The user will not see his just compiled binaries. > > So please remove this optimization.

[adg, 2013-04-08 04:46:27]

On 5 April 2013 18:38, <nightlyone@googlemail.com> wrote: > NLGTM > > It breaks mysteriously later leading to increased support load. Details > see below. > > > https://codereview.appspot.**com/8248044/diff/5001/doc/**code.html<https://co... > File doc/code.html (right): > > https://codereview.appspot.**com/8248044/diff/5001/doc/** > code.html#newcode128<https://codereview.appspot.com/8248044/diff/5001/doc/code.html#newcode128> > doc/code.html:128: $ <b>export PATH=$PATH:$GOPATH/bin</b> > This will only work in the example. But will mysteriously break, if the > user starts adding more entries to the GOPATH. > > Esp. since go writes only to the FIRST component of it and export > PATH=$PATH:$GOPATH/bin will only add the binary location of the LAST > component to the path. The user will not see his just compiled binaries. > > So please remove this optimization. > > https://codereview.appspot.**com/8248044/<https://codereview.appspot.com/8248... > We use $GOPATH elsewhere throughout this doc for a similar purpose. I think people with multiple $GOPATHs can figure it out (note that we don't even mention multiple GOPATHs in this doc). We can always change it if the support load becomes a problem. Andrew