Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(332)

Issue 7381044: Added ability to flatten drawPicture's to debugger

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by robertphillips
Modified:
12 years, 8 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Skps can have embedded SkPictures within them - which are opaque to the debugger. This CL allows the debugger to write out a flattened SkPicture to give visibility into the sub-SkPictures (when the new .skp is loaded).

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -73 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 1 chunk +5 lines, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M debugger/QT/SkSettingsWidget.h View 2 chunks +11 lines, -1 line 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 4 chunks +29 lines, -3 lines 0 comments Download
M debugger/SkDebugCanvas.h View 2 chunks +6 lines, -0 lines 0 comments Download
M debugger/SkDebugCanvas.cpp View 4 chunks +7 lines, -3 lines 0 comments Download
M debugger/SkDebugger.h View 1 chunk +2 lines, -0 lines 0 comments Download
M debugger/SkDrawCommand.h View 33 chunks +37 lines, -33 lines 2 comments Download
M debugger/SkDrawCommand.cpp View 32 chunks +37 lines, -33 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 8 months ago (2013-02-20 19:14:50 UTC) #1
DerekS
looks like we will probably implement this another way, but if you really feel like ...
12 years, 8 months ago (2013-02-21 20:42:01 UTC) #2
robertphillips
12 years, 8 months ago (2013-02-22 16:26:18 UTC) #3
Lets consider this CL parked. If anyone starts screaming for this capability we can revisit it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b