pkg/present/link.go - Issue 7312072: code review 7312072: go.talks/pkg/present: replace direct file system access...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: pkg/present/link.go

Issue 7312072: code review 7312072: go.talks/pkg/present: replace direct file system access...

Patch Set: diff -r 2e320f363bb2 https://code.google.com/p/go.talks Created 12 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: pkg/present/link.go

===================================================================

--- a/pkg/present/link.go

+++ b/pkg/present/link.go

@@ -21,7 +21,7 @@

func (l Link) TemplateName() string { return "link" }

-func parseLink(fileName string, lineno int, text string) (Elem, error) {

+func parseLink(ctx *Context, fileName string, lineno int, text string) (Elem, error) {

args := strings.Fields(text)

url, err := url.Parse(args[1])

if err != nil {

« no previous file with comments | « pkg/present/image.go ('k') | pkg/present/parse.go » ('j') | no next file with comments »