Issue 6494102: Introduce SuggestBoxBase<T extends ValueBoxBase<String>>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6494102: Introduce SuggestBoxBase<T extends ValueBoxBase<String>>

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by seanross

Modified:
13 years, 1 month ago

Reviewers:
skybrian1, t.broyer

CC:
google-web-toolkit-contributors_googlegroups.com

Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Introduce SuggestBoxBase<T extends ValueBoxBase<String>>

Patch Set 1 #

Total comments: 4

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1110 lines, -1061 lines)			Patch
M	user/src/com/google/gwt/user/client/ui/ListenerWrapper.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	user/src/com/google/gwt/user/client/ui/SuggestBox.java	View	3 chunks	+13 lines, -1054 lines	2 comments	Download
A	user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java	View	1 chunk	+1090 lines, -0 lines	2 comments	Download
M	user/src/com/google/gwt/user/client/ui/SuggestionEvent.java	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

I think I prefer the other option about changing SuggestBox. https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right): https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBox.java:104: * @see ValueBoxBase Why change this line? (I suppose it's a leftover of the other proposed patch) https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBox.java:107: public class SuggestBox extends SuggestBoxBase<TextBox> { Should be TextBoxBase here, not TextBox. https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... File user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java (right): https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:50: public class SuggestBoxBase<T extends ValueBoxBase<String>> extends Composite implements HasText, HasFocus, Javadoc https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:792: public void hideSuggestionList() { All those deprecated methods that have been moved to DefaultSuggestionDisplay should probably stay in SuggestBox.

Expand All Messages | Collapse All Messages