Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(929)

Issue 6494102: Introduce SuggestBoxBase<T extends ValueBoxBase<String>>

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by seanross
Modified:
13 years, 1 month ago
Reviewers:
skybrian1, t.broyer
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Introduce SuggestBoxBase<T extends ValueBoxBase<String>>

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1110 lines, -1061 lines) Patch
M user/src/com/google/gwt/user/client/ui/ListenerWrapper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M user/src/com/google/gwt/user/client/ui/SuggestBox.java View 3 chunks +13 lines, -1054 lines 2 comments Download
A user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java View 1 chunk +1090 lines, -0 lines 2 comments Download
M user/src/com/google/gwt/user/client/ui/SuggestionEvent.java View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1
t.broyer
13 years, 1 month ago (2012-09-10 10:34:56 UTC) #1
I think I prefer the other option about changing SuggestBox. https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right): https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBox.java:104: * @see ValueBoxBase Why change this line? (I suppose it's a leftover of the other proposed patch) https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBox.java:107: public class SuggestBox extends SuggestBoxBase<TextBox> { Should be TextBoxBase here, not TextBox. https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... File user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java (right): https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:50: public class SuggestBoxBase<T extends ValueBoxBase<String>> extends Composite implements HasText, HasFocus, Javadoc https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/cl... user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:792: public void hideSuggestionList() { All those deprecated methods that have been moved to DefaultSuggestionDisplay should probably stay in SuggestBox.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b