code review 5723050: tests: make sigchld test print "BUG:" output on failure

tests: make sigchld test print "BUG:" output on failure

[jsing, 2012-05-20 15:44:23]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

[iant2, 2012-05-20 17:48:55]

We are moving toward simple rules for tests, so that they can be run by test/run.go. This is just the cmpout rule, except not run on Windows. Perhaps the cmpout rule needs to print BUG. Either way, this should be the same as the cmpout rule, and should not have a test-specific echo. Ian jsing@google.com writes: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://go.googlecode.com/hg/ > > > Description: > tests: make sigchld test print "BUG:" output on failure > > Please review this at http://codereview.appspot.com/5723050/ > > Affected files: > M test/sigchld.go > > > Index: test/sigchld.go > =================================================================== > --- a/test/sigchld.go > +++ b/test/sigchld.go > @@ -1,5 +1,6 @@ > // [ "$GOOS" == windows ] || > -// ($G $D/$F.go && $L $F.$A && ./$A.out 2>&1 | cmp - $D/$F.out) > +// ($G $D/$F.go && $L $F.$A && ./$A.out 2>&1 | cmp - $D/$F.out || > +// echo "BUG: failed to survive SIGCHLD") > > // Copyright 2009 The Go Authors. All rights reserved. > // Use of this source code is governed by a BSD-style