code review 5696082: gotour: a few static/index tweaks for consideration

gotour: a few static/index tweaks for consideration These are some things I noticed when going through the tour locally. I pointed out some things that I think may be good for new gophers to know but aren't too advanced for a tour, and I also made fibonacci start out at 0 ;-).

[Kyle E. Lemons, 2012-02-26 20:18:52]

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

[adg, 2012-02-27 23:54:03]

http://codereview.appspot.com/5696082/diff/5001/static/index.html File static/index.html (right): http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode623 static/index.html:623: byte // Represents an ASCII value (alias of uint8) ASCII is 7-bit. A byte is a byte. byte // Alias of uint8 http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode948 static/index.html:948: Notice that the capacity only refers to the remaining length of the This sentence makes the situation more confusing. Revert this change. http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode1395 static/index.html:1395: You cannot define a method on a type from another package, on an "You cannot define a method on a basic type, an interface type, or a type from another package." http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode2062 static/index.html:2062: x, y = y, x + y can you fix the indent here too?

[Kyle E. Lemons, 2012-02-28 01:31:18]

PTAL http://codereview.appspot.com/5696082/diff/5001/static/index.html File static/index.html (right): http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode623 static/index.html:623: byte // Represents an ASCII value (alias of uint8) On 2012/02/27 23:54:04, adg wrote: > ASCII is 7-bit. A byte is a byte. > > byte // Alias of uint8 Done. Should rune then be // Alias of int32; represents a unicode code point ? http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode948 static/index.html:948: Notice that the capacity only refers to the remaining length of the On 2012/02/27 23:54:04, adg wrote: > This sentence makes the situation more confusing. Revert this change. Done. http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode1395 static/index.html:1395: You cannot define a method on a type from another package, on an On 2012/02/27 23:54:04, adg wrote: > "You cannot define a method on a basic type, an interface type, or a type from > another package." Done.

[adg, 2012-02-28 01:51:17]

On 28 February 2012 12:31, <kyle@kylelemons.net> wrote: > // Alias of int32; represents a unicode code point Yeah. 

[adg, 2012-02-28 01:53:22]

http://codereview.appspot.com/5696082/diff/4002/static/index.html File static/index.html (right): http://codereview.appspot.com/5696082/diff/4002/static/index.html#newcode310 static/index.html:310: Go, uninitialized variables are defined to have the zero value for that Replace this sentence with: A variable declared without an initial value defaults to its zero value. http://codereview.appspot.com/5696082/diff/4002/static/index.html#newcode1390 static/index.html:1390: You cannot define a method on a basic type, an interface type, tabs please http://codereview.appspot.com/5696082/diff/4002/static/index.html#newcode2031 static/index.html:2031: go fibonacci(cap(c), c) did this change to spaces? why?

[Kyle E. Lemons, 2012-02-28 02:14:23]

PTAL I turned on listchars, so maybe I got the whitespace right this time... http://codereview.appspot.com/5696082/diff/5001/static/index.html File static/index.html (right): http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode2062 static/index.html:2062: x, y = y, x + y On 2012/02/27 23:54:04, adg wrote: > can you fix the indent here too? Oops, missed one. Better? http://codereview.appspot.com/5696082/diff/4002/static/index.html File static/index.html (right): http://codereview.appspot.com/5696082/diff/4002/static/index.html#newcode2031 static/index.html:2031: go fibonacci(cap(c), c) On 2012/02/28 01:53:22, adg wrote: > did this change to spaces? why? Two of the examples down here use spaces. Not sure why. I changed them so that everything should now be using tabs.

[Kyle E. Lemons, 2012-03-03 18:18:24]

PTAL Merged in upstream changes. On 2012/02/28 02:14:23, Kyle E. Lemons wrote: > I turned on listchars, so maybe I got the whitespace right this time... > > http://codereview.appspot.com/5696082/diff/5001/static/index.html > File static/index.html (right): > > http://codereview.appspot.com/5696082/diff/5001/static/index.html#newcode2062 > static/index.html:2062: x, y = y, x + y > On 2012/02/27 23:54:04, adg wrote: > > can you fix the indent here too? > > Oops, missed one. Better? > > http://codereview.appspot.com/5696082/diff/4002/static/index.html > File static/index.html (right): > > http://codereview.appspot.com/5696082/diff/4002/static/index.html#newcode2031 > static/index.html:2031: go fibonacci(cap(c), c) > On 2012/02/28 01:53:22, adg wrote: > > did this change to spaces? why? > > Two of the examples down here use spaces. Not sure why. I changed them so that > everything should now be using tabs.

[adg, 2012-05-06 23:56:13]

LGTM

[adg, 2012-05-15 01:01:46]

Please sync and hg upload.