Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(885)

Issue 5532045: code review 5532045: goyacc: fix the panic during error recovery if $$Debug ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by renyi
Modified:
13 years, 9 months ago
Reviewers:
r, golang-dev
CC:
adg, golang-dev, gri
Visibility:
Public.

Description

goyacc: fix the panic during error recovery if $$Debug >= 2 and the generated code could not convert the token name correctly. Add the output of the rule listing in y.output to use with Russ's bisonerrors.

Patch Set 1 : diff -r 4a8268927758 https://go.googlecode.com/hg/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M src/cmd/goyacc/goyacc.go View 11 chunks +55 lines, -7 lines 0 comments Download

Messages

Total messages: 3
renyi
Hello golang-dev@googlegroups.com (cc: adg@golang.org, golang-dev@googlegroups.com, gri@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/go
13 years, 9 months ago (2012-01-08 00:49:08 UTC) #1
r
leaving for rsc; not sure about the bisonerrors stuff
13 years, 9 months ago (2012-01-09 18:52:45 UTC) #2
renyi
13 years, 9 months ago (2012-01-09 21:10:38 UTC) #3
Russ wrote bisonerrors, an awk script that resides in cmd/gc/, to generate error messages by example of state stack. Beside that, it's nice to let goyacc output the numbered list of grammar rules in y.output so I don't need to count the rules' number when reading y.output. To use the generated error message, another interface is added as not to break the current Lexer interface. - ren On Tue, Jan 10, 2012 at 2:52 AM, <r@golang.org> wrote: > leaving for rsc; not sure about the bisonerrors stuff > > http://codereview.appspot.com/**5532045/<http://codereview.appspot.com/5532045/> > 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b