Issue 5266053: Make SK_TRACE_EVENT* evaluate args in debug build (skia issue 353)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5266053: Make SK_TRACE_EVENT* evaluate args in debug build (skia issue 353)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by TomH

Modified:
12 years, 3 months ago

Reviewers:
epoger, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

We've had illegal code sitting around in TRACE_EVENT arguments before; this evaluates those args in SkDEBUGCODE() to avoid that bug happening in the future.

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	include/config/SkUserConfig.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	include/core/SkTrace.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Elliot asked to see this on 11/11/11. Maybe we should resurrect it?

Expand All Messages | Collapse All Messages