Issue 4695061: big: added recursive subdivision to nat.string to incre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4695061: big: added recursive subdivision to nat.string to incre...

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by mtj

Modified:
14 years, 3 months ago

Reviewers:
gri1, mtj1, gri

CC:
golang-dev

Visibility:
Public.

Description

big: added recursive subdivision to nat.string to increase performance 4x to 35x for medium and long length numbers. extended tests in nat_test to stress the new code and added benchmarks for performance analysis and setting the subdivision threshold. (This CL replaces #4634075 since its file info has become lost. The code here reflects changes from reviewer gri's helpful comments.)

Patch Set 1 #

Patch Set 2 : diff -r 7f39a0541e03 https://go.googlecode.com/hg/ #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+311 lines, -187 lines)			Patch
	M	src/pkg/big/nat.go	View	1	5 chunks	+192 lines, -37 lines	0 comments	Download
	M	src/pkg/big/nat_test.go	View	1	3 chunks	+119 lines, -150 lines	0 comments	Download