Add support for texture repeating with NPOT textures on GLES2

[gw280, 2011-06-17 22:12:44]

GL_MIRRORED_REPEAT functionality to come soon. Just wanted to put this out there to see if I'm going down the right route with this.

[bsalomon, 2011-06-20 14:25:51]

Hey George, I've got a couple inline comments. As I looked at this I realized that doing the repeat in the shader will be complicated when there is texture filtering. We won't be able to use the HW bilinear sampler because on the edges we have to read both sides of the domain (or unit square when no tex-domain) and not outside it. You'll have to disable the bilinear filtering and implement it in code. It would be good to start with a Sample that tests repeat with and without filtering so we can verify that it works. SampleTiling is probably a good starting point except that I believe it is using a 32x32 bitmap. Might also make it repeat more than one time to verify all the internal boundaries are correct. http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGLProgram.h File gpu/src/GrGLProgram.h (right): http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGLProgram.h#newcode173 gpu/src/GrGLProgram.h:173: GrSamplerState::WrapMode fWrapModeHorizontal; We probably want to pack these into two bytes to reduce the size of this struct http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGpuGL.cpp File gpu/src/GrGpuGL.cpp (right): http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGpuGL.cpp#newcode1815 gpu/src/GrGpuGL.cpp:1815: // ourselves When we can use GL's REPEAT, REPEAT_MIRROR because there are no texture / domain, NPOT issues we want to.

[gw280, 2011-06-22 15:37:11]

On 2011/06/20 14:25:51, bsalomon wrote: > http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGLProgram.h > File gpu/src/GrGLProgram.h (right): > > http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGLProgram.h#newcode173 > gpu/src/GrGLProgram.h:173: GrSamplerState::WrapMode fWrapModeHorizontal; > We probably want to pack these into two bytes to reduce the size of this struct Done. > http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGpuGL.cpp > File gpu/src/GrGpuGL.cpp (right): > > http://codereview.appspot.com/4650042/diff/1/gpu/src/GrGpuGL.cpp#newcode1815 > gpu/src/GrGpuGL.cpp:1815: // ourselves > When we can use GL's REPEAT, REPEAT_MIRROR because there are no texture / > domain, NPOT issues we want to. Done. Will look into GL_MIRRORED_REPEAT functionality soon.

[gw280, 2011-06-22 15:37:33]

http://codereview.appspot.com/4650042/diff/4002/gpu/include/GrGLTexture.h File gpu/include/GrGLTexture.h (right): http://codereview.appspot.com/4650042/diff/4002/gpu/include/GrGLTexture.h#new... gpu/include/GrGLTexture.h:140: bool fUseGpuRepeat; I put this in as I'm not sure how much of a runtime hit there would be to run this conditional statement both in GrGpuGL::flushGLStateCommon() and also GrGpuGLShaders::buildProgram(): if ((GrIsPow2(nextTexture->width()) && GrIsPow2(nextTexture->height())|| npotTextureTileSupport())