Issue 4570042: Fix for putImageData
| Created: 14 years, 5 months ago by gmanchromium Modified: 14 years, 5 months ago CC: skia-review_googlegroups.com Base URL: http://skia.googlecode.com/svn/trunk/gpu/ Visibility: Public. | DescriptionFix for putImageData TEST=manually ran tests that were failing BUG=84165 TBR=reed@google.com Patch Set 1 #
MessagesTotal messages: 6
Committed as http://code.google.com/p/skia/source/detail?r=1518 . Sign in to reply to this message.
Hey Mike, Justin and I found this issue. Can you take a look and make sure it looks ok? See this comment http://code.google.com/p/chromium/issues/detail?id=84165#c36 Sign in to reply to this message.
Seems right. I'll make sure brian sees it too. Sign in to reply to this message.
On 2011/06/07 11:41:01, reed1 wrote: > Seems right. I'll make sure brian sees it too. LGTM Sign in to reply to this message.
On 2011/06/07 12:39:18, bsalomon wrote: > On 2011/06/07 11:41:01, reed1 wrote: > > Seems right. I'll make sure brian sees it too. > > LGTM LGTM, too. When the modified code was originally written there was no color filter. We really should have a "reset to default" type call so that we don't have to remember to modify this code (and possibly others) every time we add state. I'll file a skia issue against myself for this. Sign in to reply to this message.
I agree. I just didn't feel comfortable doing that for the branch. Also, I want to make changes to dumpRenderTree to force it to re-init (possibly destroy and re-create) GrContext/GrDrawTarget between tests. The reason that layout tests were not failing was because previous tests were performing some state intitialization that was persisting into the following tests. Gregg picked-up on this when he realized that a test failed in isolation despite passing when executed in a larger batch. On Tue, Jun 7, 2011 at 8:43 AM, <bsalomon@google.com> wrote: > On 2011/06/07 12:39:18, bsalomon wrote: > >> On 2011/06/07 11:41:01, reed1 wrote: >> > Seems right. I'll make sure brian sees it too. >> > > LGTM >> > > LGTM, too. > > When the modified code was originally written there was no color filter. > We really should have a "reset to default" type call so that we don't > have to remember to modify this code (and possibly others) every time we > add state. I'll file a skia issue against myself for this. > > > http://codereview.appspot.com/**4570042/<http://codereview.appspot.com/4570042/> > > -- > You received this message because you are subscribed to the Google Groups > "skia-review" group. > To post to this group, send email to skia-review@googlegroups.com. > To unsubscribe from this group, send email to skia-review+unsubscribe@** > googlegroups.com <skia-review%2Bunsubscribe@googlegroups.com>. > For more options, visit this group at http://groups.google.com/** > group/skia-review?hl=en <http://groups.google.com/group/skia-review?hl=en> > . > > Sign in to reply to this message. | ||||||||||||||||||||||||||||||||||||||||||
