Add NEON runtime detection for ARM platforms

[jammy.zhou, 2011-03-31 06:04:09]

Besides adding NEON runtime detection for ARM platforms, this patchset also adds support for building standalone skia on ARM platforms

[reed1, 2011-03-31 19:56:45]

Thanks for the submission. This change is pretty big, and will take time to both understand the plumbing changes, and verify/measure the assembly routines. Is it possible to break this into several smaller CLs? What device(s) did you use to test the assembly? Do you have any relative performance timings with and without your change?

[jammy.zhou, 2011-04-01 01:38:44]

Thanks for the quick response, reed. I will try to separate the patchset into smaller ones. I tested the patchset on Freescale imx51 ARM platform with NEON support. And I plan to test it on NVidia Tegra2 platform without NEON. Of course, it was also tested on x86 platform. I will performance data as well after I separate the patchset into smaller ones. 2011/4/1 <reed@google.com> > Thanks for the submission. > > This change is pretty big, and will take time to both understand the > plumbing changes, and verify/measure the assembly routines. > > Is it possible to break this into several smaller CLs? > > What device(s) did you use to test the assembly? Do you have any > relative performance timings with and without your change? > > > http://codereview.appspot.com/4323046/ > 

[jammy.zhou, 2011-04-07 01:34:00]

Hi reed, I have separated this patch into seven smaller ones using git-svn, and these patches are in my local git branch. But when using upload.py, I met error message below, it seems that upload.py cannot identify local git commits. Could you please indicate what shall I do to send such patch series out for review with upload.py? Or is there any other method besides using upload.py? ======== jammy@jammy-ThinkPad-T400:~/skia-git$ ./upload.py -i 4323046 --rev 1037 -r reed@google.com -v 2011-04-07 09:27:05 INFO upload.py:691 Running ['hg', 'root'] 2011-04-07 09:27:05 INFO upload.py:691 Running ['git', 'rev-parse', '--is-inside-work-tree'] 2011-04-07 09:27:05 INFO upload.py:691 Running ['git', 'ls-files', '--exclude-standard', '--others'] The following files are not added to version control: results.txt upload.py Are you sure to continue?(y/N) y 2011-04-07 09:27:06 INFO upload.py:691 Running ['git', 'diff', '--no-ext-diff', '--full-index', '-M', '1037'] Got error status from ['git', 'diff', '--no-ext-diff', '--full-index', '-M', '1037']: Thanks, Jammy On 2011/03/31 19:56:45, reed1 wrote: > Thanks for the submission. > > This change is pretty big, and will take time to both understand the plumbing > changes, and verify/measure the assembly routines. > > Is it possible to break this into several smaller CLs? > > What device(s) did you use to test the assembly? Do you have any relative > performance timings with and without your change?

[jammy.zhou, 2011-04-11 01:30:49]

I have submitted my patches to my skia branch at git.linaro.org, please review. http://git.linaro.org/gitweb?p=people/jammy-zhou/skia.git;a=summary The test results on EfikaMX SmartBook (Freescale IMX51 ARM Cortex A8) are quite similar for enable NEON at build time and detect NEON capability at runtime. ====== Enable __ARM_HAVE_NEON code path without my patches: http://pastebin.com/621fuVVb Enable NEON runtime detection with my patches: http://pastebin.com/cC2L7EC7 By the way, one bug has been reported for the segfault in arm_memset32(), see http://code.google.com/p/skia/issues/detail?id=201.

[jammy.zhou, 2011-04-18 02:34:24]

Hi reed, Could you please review my patches in http://git.linaro.org/gitweb?p=people/jammy-zhou/skia.git;a=summary? Thanks, Jammy