code review 31810043: net/http: empty contenty-type treated as application/oc...

net/http: empty content-type treated as application/octet-stream RFC 2616, section 7.2.1 - empty type SHOULD be treated as application/octet-stream. Fixes issue 6616.

[j.czarnowicz, 2013-11-24 23:49:32]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

[gobot, 2013-12-18 18:02:55]

R=bradfitz@golang.org (assigned by rsc@google.com)

[bradfitz, 2013-12-18 18:11:18]

Please sign the CLA. See http://golang.org/doc/contribute.html#copyright Also, two typos. One in CL description: "contenty-type" And one below: https://codereview.appspot.com/31810043/diff/40001/src/pkg/net/http/request_t... File src/pkg/net/http/request_test.go (right): https://codereview.appspot.com/31810043/diff/40001/src/pkg/net/http/request_t... src/pkg/net/http/request_test.go:71: // Empty content type is legal - shoult be treated as typo: should

[josharian, 2013-12-18 19:54:25]

https://codereview.appspot.com/31810043/diff/40001/src/pkg/net/http/request.go File src/pkg/net/http/request.go (right): https://codereview.appspot.com/31810043/diff/40001/src/pkg/net/http/request.g... src/pkg/net/http/request.go:685: ct, _, err = mime.ParseMediaType(ct) Seems like mime.ParseMediaType could go in an else here, since "application/octet-stream" is already normalized.

[gobot, 2013-12-20 16:26:05]

Replacing golang-dev with golang-codereviews.

[bradfitz, 2013-12-20 19:49:37]

LGTM On Fri, Dec 20, 2013 at 8:26 AM, <gobot@golang.org> wrote: > Replacing golang-dev with golang-codereviews. > > https://codereview.appspot.com/31810043/ > 

[bradfitz, 2013-12-20 19:49:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=a768c0592b88 *** net/http: empty contenty-type treated as application/octet-stream RFC 2616, section 7.2.1 - empty type SHOULD be treated as application/octet-stream. Fixes issue 6616. R=golang-codereviews, gobot, bradfitz, josharian CC=golang-codereviews https://codereview.appspot.com/31810043 Committer: Brad Fitzpatrick <bradfitz@golang.org>