Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1115)

Issue 220380043: Fix table_builder to have matching sort arrows, and add transition.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by aiolos
Modified:
10 years, 5 months ago
Reviewers:
nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
https://github.com/google/trace-viewer@master
Visibility:
Public.

Description

Fix table_builder to have mathcing sort arrows, and add transition. BUG=860

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M trace_viewer/core/analysis/table_builder.html View 2 chunks +16 lines, -1 line 3 comments Download

Messages

Total messages: 3
aiolos
https://codereview.appspot.com/220380043/diff/1/trace_viewer/core/analysis/table_builder.html File trace_viewer/core/analysis/table_builder.html (right): https://codereview.appspot.com/220380043/diff/1/trace_viewer/core/analysis/table_builder.html#newcode538 trace_viewer/core/analysis/table_builder.html:538: var descendingArrow = String.fromCharCode(0x25B4); Is there a preferred way ...
10 years, 7 months ago (2015-03-27 18:24:36 UTC) #1
nduca
https://codereview.appspot.com/220380043/diff/1/trace_viewer/core/analysis/table_builder.html File trace_viewer/core/analysis/table_builder.html (right): https://codereview.appspot.com/220380043/diff/1/trace_viewer/core/analysis/table_builder.html#newcode507 trace_viewer/core/analysis/table_builder.html:507: transform: scale(1, -1); negative scales do funky things...how about ...
10 years, 7 months ago (2015-03-27 19:18:46 UTC) #2
dsinclair
10 years, 5 months ago (2015-05-20 16:49:52 UTC) #3
 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b