Issue 214100044: Added a [foreground line] + [background slice] mode to the counter UI.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 214100044: Added a [foreground line] + [background slice] mode to the counter UI.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by aschulman_google

Modified:
10 years, 7 months ago

Reviewers:
nduca

CC:
trace-viewer-review_googlegroups.com

Base URL:
https://github.com/google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Added a [foreground line] + [background slice] mode to the counter UI. This is a compact way of visualizing counters that have a binary value (e.g., power on/off) and a real value (e.g., voltage).

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -2 lines)			Patch
M	trace_viewer/core/trace_model/counter.html	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	trace_viewer/core/tracks/counter_track.html	View	4 chunks	+47 lines, -2 lines	0 comments	Download
M	trace_viewer/core/tracks/counter_track_test.html	View	1 chunk	+39 lines, -0 lines	0 comments	Download