code review 1773041: crypto/rand for Windows

src/pkg/crypto/x509/x509_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package x509
 
 import (
 "big"
+"crypto/rand"
 "crypto/rsa"
 "encoding/hex"
 "encoding/pem"
-"os"
 "reflect"
 "testing"
 "time"
 )
 
 func TestParsePKCS1PrivateKey(t *testing.T) {
 block, _ := pem.Decode([]byte(pemPrivateKey))
 priv, err := ParsePKCS1PrivateKey(block.Bytes)
 if err != nil {
 t.Errorf("Failed to parse private key: %s", err)
@@ skipping 115 matching lines @@
 "8620687474703a2f2f63726c2e766572697369676e2e636f6d2f706361332e63726c303 206082b" +
 "0601050507010104263024302206082b060105050730018616687474703a2f2f6f63737 02e7468" +
 "617774652e636f6d30340603551d25042d302b06082b0601050507030106082b0601050 5070302" +
 "06096086480186f8420401060a6086480186f845010801300d06092a864886f70d01010 5050003" +
 "81810055ac63eadea1ddd2905f9f0bce76be13518f93d9052bc81b774bad6950a1eeded cfddb07" +
 "e9e83994dcab72792f06bfab8170c4a8edea5334edef1e53d906c7562bd15cf4d18a8eb 42bb137" +
 "9048084225c53e8acb7feb6f04d16dc574a2f7a27c7b603c77cd0ece48027f012fb69b3 7e02a2a" +
 "36dcd585d6ace53f546f961e05af"
 
 func TestCreateSelfSignedCertificate(t *testing.T) {
-  urandom, err := os.Open("/dev/urandom", os.O_RDONLY, 0)
-  if err != nil {
-    t.Errorf("failed to open /dev/urandom")
+  random := rand.Reader
+  if random == nil {

[rsc1, 2010/07/12 20:15:30]

delete 

[peterGo, 2010/07/12 21:06:33]

Done. 

+    t.Errorf("Failed to find a random reader")
 }
 
 block, _ := pem.Decode([]byte(pemPrivateKey))
 priv, err := ParsePKCS1PrivateKey(block.Bytes)
 if err != nil {
 t.Errorf("Failed to parse private key: %s", err)
 return
 }
 
 template := Certificate{
 SerialNumber: []byte{1},
 Subject: Name{
 CommonName: "test.example.com",
 Organization: "Acme Co",
 },
 NotBefore: time.SecondsToUTC(1000),
 NotAfter: time.SecondsToUTC(100000),
 
 SubjectKeyId: []byte{1, 2, 3, 4},
 KeyUsage: KeyUsageCertSign,
 
 BasicConstraintsValid: true,
 IsCA: true,
 DNSNames: []string{"test.example.com"},
 }
 
-  derBytes, err := CreateCertificate(urandom, &template, &template, &priv.  PublicKey, priv)
+  derBytes, err := CreateCertificate(random, &template, &template, &priv.P  ublicKey, priv)
 if err != nil {
 t.Errorf("Failed to create certificate: %s", err)
 return
 }
 
 cert, err := ParseCertificate(derBytes)
 if err != nil {
 t.Errorf("Failed to parse certificate: %s", err)
 return
 }
 err = cert.CheckSignatureFrom(cert)
 if err != nil {
 t.Errorf("Signature verification failed: %s", err)
 return
 }
 }