code review 1773041: crypto/rand for Windows

src/pkg/crypto/rsa/rsa_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package rsa
 
 import (
 "big"
 "bytes"
+"crypto/rand"
 "crypto/sha1"
-"os"
 "testing"
 )
 
 func TestKeyGeneration(t *testing.T) {
-  urandom, err := os.Open("/dev/urandom", os.O_RDONLY, 0)
-  if err != nil {
-    t.Errorf("failed to open /dev/urandom")
+  random := rand.Reader
+  if random == nil {

[rsc1, 2010/07/12 20:15:30]

delete 

[peterGo, 2010/07/12 21:06:33]

Done. 

+    t.Errorf("Failed to find a random reader")
 }
 
-  priv, err := GenerateKey(urandom, 1024)
+  priv, err := GenerateKey(random, 1024)
 if err != nil {
 t.Errorf("failed to generate key")
 }
 pub := &priv.PublicKey
 m := big.NewInt(42)
 c := encrypt(new(big.Int), pub, m)
 m2, err := decrypt(nil, priv, c)
 if err != nil {
 t.Errorf("error while decrypting: %s", err)
 }
 if m.Cmp(m2) != 0 {
 t.Errorf("got:%v, want:%v (%s)", m2, m, priv)
 }
 
-  m3, err := decrypt(urandom, priv, c)
+  m3, err := decrypt(random, priv, c)
 if err != nil {
 t.Errorf("error while decrypting (blind): %s", err)
 }
 if m.Cmp(m3) != 0 {
 t.Errorf("(blind) got:%v, want:%v", m3, m)
 }
 }
 
 type testEncryptOAEPMessage struct {
 in []byte
@@ skipping 22 matching lines @@
 t.Errorf("#%d,%d error: %s", i, j, err)
 }
 if bytes.Compare(out, message.out) != 0 {
 t.Errorf("#%d,%d bad result: %s (want %s)", i, j , out, message.out)
 }
 }
 }
 }
 
 func TestDecryptOAEP(t *testing.T) {
-  urandom, err := os.Open("/dev/urandom", os.O_RDONLY, 0)
-  if err != nil {
-    t.Errorf("Failed to open /dev/urandom")
+  random := rand.Reader
+  if random == nil {

[rsc1, 2010/07/12 20:15:30]

delete 

[peterGo, 2010/07/12 21:06:33]

Done. 

+    t.Errorf("Failed to find a random reader")
 }
 
 sha1 := sha1.New()
 n := new(big.Int)
 d := new(big.Int)
 for i, test := range testEncryptOAEPData {
 n.SetString(test.modulus, 16)
 d.SetString(test.d, 16)
 private := PrivateKey{PublicKey{n, test.e}, d, nil, nil}
 
 for j, message := range test.msgs {
 out, err := DecryptOAEP(sha1, nil, &private, message.out , nil)
 if err != nil {
 t.Errorf("#%d,%d error: %s", i, j, err)
 } else if bytes.Compare(out, message.in) != 0 {
 t.Errorf("#%d,%d bad result: %#v (want %#v)", i, j, out, message.in)
 }
 
 // Decrypt with blinding.
-      out, err = DecryptOAEP(sha1, urandom, &private, message.  out, nil)
+      out, err = DecryptOAEP(sha1, random, &private, message.o  ut, nil)
 if err != nil {
 t.Errorf("#%d,%d (blind) error: %s", i, j, err)
 } else if bytes.Compare(out, message.in) != 0 {
 t.Errorf("#%d,%d (blind) bad result: %#v (want % #v)", i, j, out, message.in)
 }
 }
 }
 }
 
 // testEncryptOAEPData contains a subset of the vectors from RSA's "Test vectors for RSA-OAEP".
@@ skipping 135 matching lines @@
 0x5e, 0x7f, 0x16, 0x64, 0x61, 0x82, 0xfd , 0xb4, 0x64,
 0x73, 0x9b, 0x68, 0xab, 0x5d, 0xaf, 0xf0 , 0xe6, 0x3e,
 0x95, 0x52, 0x01, 0x68, 0x24, 0xf0, 0x54 , 0xbf, 0x4d,
 0x3c, 0x8c, 0x90, 0xa9, 0x7b, 0xb6, 0xb6 , 0x55, 0x32,
 0x84, 0xeb, 0x42, 0x9f, 0xcc,
 },
 },
 },
 },
 }