cloud/pubsub: Adding integration tests

cloud/pubsub: Adding integration tests

[djd, 2014-10-23 22:57:33]

https://codereview.appspot.com/158440043/diff/1/pubsub/integration_test.go File pubsub/integration_test.go (right): https://codereview.appspot.com/158440043/diff/1/pubsub/integration_test.go#ne... pubsub/integration_test.go:43: ctx = testContext(t) This makes me nervous, and it's a bit fragile. Instead could you initialise topic and subscription at pkg init time, and make the context per test? var (	topic = fmt.Sprintf("topic-%d", time.Now().Unix())	sub = fmt.Sprintf("subscription-%d", time.Now().Unix()) ) https://codereview.appspot.com/158440043/diff/1/pubsub/integration_test.go#ne... pubsub/integration_test.go:54: func TestSubCreate(t *testing.T) { Actually, reading a bit, all these tests need to run in the given order. Better to make it just one big test I think. You might need a bit more context in the t.Error calls so it's obvious which API call is failing. But at least it makes it obvious that the stages are connected.

[jbd, 2014-10-23 23:37:17]

https://codereview.appspot.com/158440043/diff/1/pubsub/integration_test.go File pubsub/integration_test.go (right): https://codereview.appspot.com/158440043/diff/1/pubsub/integration_test.go#ne... pubsub/integration_test.go:54: func TestSubCreate(t *testing.T) { On 2014/10/23 22:57:33, djd wrote: > Actually, reading a bit, all these tests need to run in the given order. Better > to make it just one big test I think. You might need a bit more context in the > t.Error calls so it's obvious which API call is failing. But at least it makes > it obvious that the stages are connected. Agreed and done. Storage integration tests might need some cleanup as well.

[djd, 2014-10-23 23:45:44]

LGTM

[jbd, 2014-10-23 23:58:31]

Submitted as 6226f9f5951458eb555fd799e2b2c8573fe7955c.