code review 14283043: go.tools/vcs: allow compilation with go 1.0

go.tools/vcs: allow compilation with go 1.0 It would be nice to be able to use this package as a dependency (or other go utilities in the ecosystem that depend on this package) in environments which have not (or cannot) for whatever reason upgraded to newer versions of golang.

[mreiferson, 2013-10-02 15:10:27]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

[adg, 2013-10-03 02:59:53]

Have you signed the Contributor License Agreement? http://golang.org/doc/contribute.html#copyright 

[adg, 2013-10-03 03:01:07]

Normally we wouldn't bother keeping go.tools compatible with old versions of Go, but since this change is so tiny I'm inclined to allow it. Note that the VCS package may break under Go 1.0 for other reasons in the future. We're not going to expend effort keeping it compatible. 

[mreiferson, 2013-10-03 12:05:16]

Thanks, Just signed the contributor agreement. I understand, it just seems like it's worthwhile if possible and reasonable. On Wed, Oct 2, 2013 at 11:00 PM, Andrew Gerrand <adg@golang.org> wrote: > Normally we wouldn't bother keeping go.tools compatible with old versions > of Go, but since this change is so tiny I'm inclined to allow it. > Note that the VCS package may break under Go 1.0 for other reasons in the > future. We're not going to expend effort keeping it compatible. > > -- > > --- > You received this message because you are subscribed to the Google Groups > "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > 

[adg, 2013-10-04 01:47:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=43a281dd07af&repo=tools *** go.tools/vcs: allow compilation with go 1.0 It would be nice to be able to use this package as a dependency (or other go utilities in the ecosystem that depend on this package) in environments which have not (or cannot) for whatever reason upgraded to newer versions of golang. R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/14283043 Committer: Andrew Gerrand <adg@golang.org>