Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 138320043: go.talks: Talk at OpenDNS

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by francesc
Modified:
11 years, 1 month ago
Reviewers:
adg
Visibility:
Public.

Description

go.talks: Talk at OpenDNS

Patch Set 1 #

Patch Set 2 : diff -r 7094cf573469ad6baa128f4c67e970f044a53338 https://code.google.com/p/go.talks #

Total comments: 1

Patch Set 3 : diff -r 7094cf573469ad6baa128f4c67e970f044a53338 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1023 lines, -0 lines) Patch
A 2014/openlate.slide View 1 2 1 chunk +528 lines, -0 lines 0 comments Download
A 2014/openlate/BadInheritance.java View 1 1 chunk +82 lines, -0 lines 0 comments Download
A 2014/openlate/Composition.java View 1 1 chunk +86 lines, -0 lines 0 comments Download
A 2014/openlate/battle.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
A 2014/openlate/chan.go View 1 1 chunk +26 lines, -0 lines 0 comments Download
A 2014/openlate/conc1.go View 1 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/openlate/conc2.go View 1 1 chunk +20 lines, -0 lines 0 comments Download
A 2014/openlate/conc3.go View 1 1 chunk +21 lines, -0 lines 0 comments Download
A 2014/openlate/embedsample.go View 1 1 chunk +22 lines, -0 lines 0 comments Download
A 2014/openlate/goodcounter.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
A 2014/openlate/goroutines.go View 1 1 chunk +30 lines, -0 lines 0 comments Download
A 2014/openlate/img/badinheritance.png View 1 Binary file 0 comments Download
A 2014/openlate/img/busy.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/chain.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/conc.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/duck.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/funcdraw.png View 1 Binary file 0 comments Download
A 2014/openlate/img/funnelin.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/gopher.jpg View 1 Binary file 0 comments Download
A 2014/openlate/img/trends.png View 1 Binary file 0 comments Download
A 2014/openlate/loopback.go View 1 1 chunk +25 lines, -0 lines 0 comments Download
A 2014/openlate/runner/embed.go View 1 1 chunk +25 lines, -0 lines 0 comments Download
A 2014/openlate/runner/runner.go View 1 1 chunk +55 lines, -0 lines 0 comments Download
A 2014/openlate/writecounter.go View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Looks fine. Didn't see any egregious typos. https://codereview.appspot.com/138320043/diff/20001/2014/openlate.slide File 2014/openlate.slide (right): https://codereview.appspot.com/138320043/diff/20001/2014/openlate.slide#newcode342 2014/openlate.slide:342: * RunCounter ...
11 years, 1 month ago (2014-09-10 01:18:11 UTC) #1
francesc
On 2014/09/10 01:18:11, adg wrote: > Looks fine. Didn't see any egregious typos. > > ...
11 years, 1 month ago (2014-09-11 04:42:40 UTC) #2
adg
11 years, 1 month ago (2014-09-11 04:45:24 UTC) #3
Since it's a combination of earlier talks you've given (already on talks.golang.org?), maybe just put them on github. On 11 September 2014 14:42, <campoy@golang.org> wrote: > Reviewers: adg, > > Message: > On 2014/09/10 01:18:11, adg wrote: > >> Looks fine. Didn't see any egregious typos. >> > > > https://codereview.appspot.com/138320043/diff/20001/2014/openlate.slide > >> File 2014/openlate.slide (right): >> > > > https://codereview.appspot.com/138320043/diff/20001/2014/ > openlate.slide#newcode342 > >> 2014/openlate.slide:342: * RunCounter is-a Runner that counts >> is a? >> > > People really enjoyed the talk and asked for the slides. Should we go > through formal review here and get them on talks.golang.org or should I > just upload them somewhere else like github? > > Description: > go.talks: Talk at OpenDNS > > Please review this at https://codereview.appspot.com/138320043/ > > Affected files (+1014, --9 lines): > A 2014/openlate.slide > A 2014/openlate/BadInheritance.java > A 2014/openlate/Composition.java > A 2014/openlate/battle.go > A 2014/openlate/chan.go > A 2014/openlate/conc1.go > A 2014/openlate/conc2.go > A 2014/openlate/conc3.go > A 2014/openlate/embedsample.go > A 2014/openlate/goodcounter.go > A 2014/openlate/goroutines.go > A 2014/openlate/img/badinheritance.png > A 2014/openlate/img/busy.jpg > A 2014/openlate/img/chain.jpg > A 2014/openlate/img/conc.jpg > A 2014/openlate/img/duck.jpg > A 2014/openlate/img/funcdraw.png > A 2014/openlate/img/funnelin.jpg > A 2014/openlate/img/gopher.jpg > A 2014/openlate/img/trends.png > A 2014/openlate/loopback.go > A 2014/openlate/runner/embed.go > A 2014/openlate/runner/runner.go > A 2014/openlate/writecounter.go > > > 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b