Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1007)

Issue 13433043: Changes to support One-Click Revert in Rietveld

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rmistry
Modified:
12 years, 1 month ago
Reviewers:
iannucci
CC:
M-A, cmp, skiabot_google.com
Visibility:
Public.

Description

Changes to support One-Click Revert in Rietveld. * Added a 'Revert' checkbox next to the 'Commit' checkbox. The checkbox is enabled only when an issue is closed. Mousing over the popup displays a message that says that this functionality may not be available for all projects. * Added revert and reverted_by fields to the Issue data model. * Can now search for reverted and closed issues. * Added a new /<issue>/open URL that re-opens the specified issue. * revert and reverted_by fields are cleared when an issue is re-opened. Design document is here: http://goto/OneClickRevert (available internally) Changes are staged here: https://skia-codereview-staging.appspot.com/12001/ Part of a set of CLs that adds functionality to depot_tools, CQ and Rietveld- https://codereview.chromium.org/23618017/ : Changes to support One-Click Revert in depot_tools. https://codereview.chromium.org/23483019/ : Changes to support One-Click Revert in Commit Queue. https://codereview.appspot.com/13433043/ : Changes to support One-Click Revert in Chromium Rietveld. Tested with: * Unit tests have been added. * I also tested end-to-end using a skiabot-test repository in https://skia.googlesource.com/ (it is hidden). CLs I tested with are: ** https://skia-codereview-staging.appspot.com/12001/ : Adding file4. ** https://skia-codereview-staging.appspot.com/18001/ : Deleting 2 files. Adding 1 binary file. Modifying 1 file.

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Clear revert bit when issue is reopened #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : Adding popup info msg for Revert checkbox #

Patch Set 8 : Minor cleanup #

Patch Set 9 : Adding a CL_NUM/open url #

Patch Set 10 : Minor fix #

Patch Set 11 : Experiment #

Patch Set 12 : Save email of user who triggered the revert #

Patch Set 13 : Minor cleanup #

Patch Set 14 : Minor cleanup #

Patch Set 15 : Removing temporary testing code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
M codereview/models.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M codereview/urls.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M codereview/views.py View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +27 lines, -0 lines 0 comments Download
M codereview/views_chromium.py View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +12 lines, -1 line 0 comments Download
M index.yaml View 1 chunk +20 lines, -0 lines 0 comments Download
M static/script.js View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download
M static/styles.css View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M templates/patchset.html View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1
rmistry
12 years, 1 month ago (2013-09-05 19:00:21 UTC) #1
 
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b