Issue 131730043: Tweak regression test for async slices.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131730043: Tweak regression test for async slices.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by jeffbrown

Modified:
11 years, 3 months ago

Reviewers:
nduca

CC:
trace-viewer-review_googlegroups.com

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Tweak regression test for async slices. A previous version of trace viewer had a bug where async slices would not be closed correctly if they ended on a different thread than where they started. As it happens, this bug was fixed but some misleading comments were left behind. This change cleans this up a little and ensures that the unit test exercises the case which previously failed.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	trace_viewer/tracing/importer/linux_perf/android_parser.html	View		1 chunk	+7 lines, -8 lines	0 comments	Download
	M	trace_viewer/tracing/importer/linux_perf/android_parser_test.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download