Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(454)

Issue 120180043: Add firstSslTime metric to devtools.inc.php

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by mgl
Modified:
11 years, 3 months ago
Reviewers:
pmeenan
CC:
wrightt
Base URL:
https://github.com/geening/webpagetest.git@master
Visibility:
Public.

Description

Add firstSslTime metric to devtools.inc.php BUG=

Patch Set 1 #

Patch Set 2 : Revisions to base page SSL code #

Total comments: 1

Patch Set 3 : Allow basePageSSLTime to be zero. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M www/benchmarks/compare.php View 1 1 chunk +1 line, -0 lines 0 comments Download
M www/benchmarks/cron.php View 1 2 1 chunk +1 line, -1 line 0 comments Download
M www/benchmarks/delta.php View 1 1 chunk +1 line, -0 lines 0 comments Download
M www/benchmarks/trendurl.php View 1 1 chunk +1 line, -0 lines 0 comments Download
M www/benchmarks/view.php View 1 1 chunk +1 line, -0 lines 0 comments Download
M www/benchmarks/viewtest.php View 1 1 chunk +1 line, -0 lines 0 comments Download
M www/devtools.inc.php View 1 2 chunks +8 lines, -2 lines 0 comments Download
M www/graph_page_data.php View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
mgl
This doesn't quite work (the first SSL connection time graph is blank on http://localhost/graph_page_data.php?tests=140717_P0_2EY-l%3AGoogle%2C140717_BV_2EZ-l%3ABing+HTTP%2C140717_CG_2F0-l%3ABing+HTTPS&medianMetric=loadTime&fv=1&control=0) Any ...
11 years, 3 months ago (2014-07-25 16:55:00 UTC) #1
mgl
On 2014/07/25 16:55:00, mgl wrote: > This doesn't quite work (the first SSL connection time ...
11 years, 3 months ago (2014-07-25 16:58:53 UTC) #2
pmeenan
Looks good other than one change. https://codereview.appspot.com/120180043/diff/20001/www/benchmarks/cron.php File www/benchmarks/cron.php (right): https://codereview.appspot.com/120180043/diff/20001/www/benchmarks/cron.php#newcode23 www/benchmarks/cron.php:23: $nonZero = array('TTFB', ...
11 years, 3 months ago (2014-07-25 19:38:27 UTC) #3
mgl
On 2014/07/25 19:38:27, pmeenan wrote: > Looks good other than one change. > > https://codereview.appspot.com/120180043/diff/20001/www/benchmarks/cron.php ...
11 years, 3 months ago (2014-07-25 19:51:13 UTC) #4
pmeenan
11 years, 3 months ago (2014-07-26 00:22:05 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b