Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Unified Diff: www/benchmarks/compare.php

Issue 109000048: Add links to multitest comparison graph view from scatterplots. Make numRunsFromTestInfo return zer… Base URL: https://github.com/geening/webpagetest.git@master
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | www/benchmarks/viewtest.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: www/benchmarks/compare.php
diff --git a/www/benchmarks/compare.php b/www/benchmarks/compare.php
index 6791e3e062f2891fde133c3776388162cd053001..c4dc75732bc38c5652e56940845c450f33e54312 100644
--- a/www/benchmarks/compare.php
+++ b/www/benchmarks/compare.php
@@ -186,14 +186,19 @@ foreach ($benchmarks as &$benchmark) {
?>
var menu = '<div><h4>View test for ' + url + '</h4>';
var compare = "/video/compare.php?ival=100&medianMetric=" + medianMetric + "&tests=";
+ var graph_compare = "/graph_page_data.php?tests=";
for( i = 0; i < tests.length; i++ ) {
menu += '<a href="/result/' + tests[i] + '/?medianMetric=' + medianMetric + '" target="_blank">' + seriesData[i].name + '</a><br>';
if (i) {
compare += ",";
+ graph_compare += ",";
}
compare += encodeURIComponent(tests[i] + "-l:" + seriesData[i].name.replace("-","").replace(":","") + "-c:" + (cached ? 1 : 0));
+ graph_compare += encodeURIComponent(tests[i]);
}
+ graph_compare += "&" + (cached ? "rv" : "fv") + "=1";
menu += '<br><a href="' + compare + '">Filmstrip Comparison</a>';
+ menu += '<br><a href="' + graph_compare + '">Graph Comparison</a>';
menu += '</div>';
$.modal(menu, {overlayClose:true});
}
« no previous file with comments | « no previous file | www/benchmarks/viewtest.php » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b