go.tools/go/types: type the append([]byte, string...) b...

go.tools/go/types: type the append([]byte, string...) builtin more correctly This builtin is a little weird in this form as it is (to my knowledge) the only function that takes a variadic argument of non-slice type. The language provides no syntax to express this, so we pick a stringification for such arguments that does not appear in the language. Specifically, use T... instead of ...T to distinguish it from the normal case where the type is a slice. This change lets the go/ssa package produce more efficient IR by avoiding an extra conversion of the second argument.

[gri, 2014-06-27 22:45:43]

LGTM Can you explain in the CL desc which problem this solves? Presumably you need this for further processing? Also, have you verified that this doesn't break any of Alan's code?

[pcc, 2014-06-27 22:54:31]

On 2014/06/27 22:45:43, gri wrote: > LGTM > > Can you explain in the CL desc which problem this solves? Presumably you need > this for further processing? Done. > Also, have you verified that this doesn't break any of Alan's code? Yes, I ran the go/ssa/... test suite.

[gri, 2014-06-27 23:00:42]

LGTM

[gri, 2014-06-27 23:00:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=5e316c800d33&repo=tools *** go.tools/go/types: type the append([]byte, string...) builtin more correctly This builtin is a little weird in this form as it is (to my knowledge) the only function that takes a variadic argument of non-slice type. The language provides no syntax to express this, so we pick a stringification for such arguments that does not appear in the language. Specifically, use T... instead of ...T to distinguish it from the normal case where the type is a slice. This change lets the go/ssa package produce more efficient IR by avoiding an extra conversion of the second argument. LGTM=gri R=gri CC=adonovan, golang-codereviews https://codereview.appspot.com/108230044 Committer: Robert Griesemer <gri@golang.org>

[adonovan, 2014-06-29 11:08:28]

https://codereview.appspot.com/108230044/diff/40001/go/types/typestring.go File go/types/typestring.go (right): https://codereview.appspot.com/108230044/diff/40001/go/types/typestring.go#ne... go/types/typestring.go:224: writeType(buf, this, typ, visited) A comment would be good here. Also, please update the Signature type docstring to mention that isvariadic implies either that the last param type is an unnamed slice type OR a string (in the special case of the append builtin).

[gri, 2014-09-13 00:29:25]

https://codereview.appspot.com/108230044/diff/40001/go/types/typestring.go File go/types/typestring.go (right): https://codereview.appspot.com/108230044/diff/40001/go/types/typestring.go#ne... go/types/typestring.go:224: writeType(buf, this, typ, visited) On 2014/06/29 11:08:28, adonovan wrote: > A comment would be good here. > > Also, please update the Signature type docstring to mention that isvariadic > implies either that the last param type is an unnamed slice type OR a string (in > the special case of the append builtin). Done.