Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(260)

Issue 106060045: code review 106060045: misc/emacs: when parsing GOPATH, use the platform-depen...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Dominik Honnef
Modified:
11 years, 3 months ago
Reviewers:
ruiu, dave, adonovan
CC:
golang-codereviews
Visibility:
Public.

Description

misc/emacs: when parsing GOPATH, use the platform-dependent path separator path-separator is a built-in variable in Emacs that will contain the right path separator depending on the platform.

Patch Set 1 #

Patch Set 2 : diff -r 777dd5a434db https://code.google.com/p/go #

Patch Set 3 : diff -r 777dd5a434db https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/emacs/go-mode.el View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Dominik Honnef
Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2014-06-18 01:36:31 UTC) #1
ruiu
LGTM
11 years, 4 months ago (2014-06-18 01:45:43 UTC) #2
Dominik Honnef
Let's review this thoroughly though and give it at least 48 hours ;-)
11 years, 4 months ago (2014-06-18 01:51:31 UTC) #3
ruiu
:) But actually we now have quite a few pending patches to this file, so ...
11 years, 4 months ago (2014-06-18 02:03:13 UTC) #4
dave_cheney.net
11 years, 3 months ago (2014-07-16 11:04:42 UTC) #5
R=close the emacs bindings have moved to a better place (for an indeterminate value of better)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b